10.03.2015 20:23, Aneesh Kumar K.V wrote:
[]>
> I am not sure this is needed, whether to use int err or int ret as the
> variable name is simply a matter of preference for the author.
We have 2 filesystem methods in here, read and write, one near another,
which are written by the same author (but
Michael Tokarev writes:
> Don't compare syscall return with -1, use "<0" condition.
> Don't introduce useless local variables when we already
> have similar variable
> Rename local variable to be consistent with other usages
>
> Signed-off-by: Michael Tokarev
> ---
> hw/9pfs/virtio-9p-proxy.c |
On 2015/3/10 15:20, Michael Tokarev wrote:
> 10.03.2015 10:15, Gonglei wrote:
>> On 2015/3/10 13:54, Michael Tokarev wrote:
>>> Don't compare syscall return with -1, use "<0" condition.
>>> Don't introduce useless local variables when we already
>>> have similar variable
>>> Rename local variable t
10.03.2015 10:15, Gonglei wrote:
> On 2015/3/10 13:54, Michael Tokarev wrote:
>> Don't compare syscall return with -1, use "<0" condition.
>> Don't introduce useless local variables when we already
>> have similar variable
>> Rename local variable to be consistent with other usages
>>
>> Signed-off
On 2015/3/10 13:54, Michael Tokarev wrote:
> Don't compare syscall return with -1, use "<0" condition.
> Don't introduce useless local variables when we already
> have similar variable
> Rename local variable to be consistent with other usages
>
> Signed-off-by: Michael Tokarev
> ---
> hw/9pfs/v
Don't compare syscall return with -1, use "<0" condition.
Don't introduce useless local variables when we already
have similar variable
Rename local variable to be consistent with other usages
Signed-off-by: Michael Tokarev
---
hw/9pfs/virtio-9p-proxy.c | 12 +---
1 file changed, 5 inser
