Re: [Qemu-devel] [PATCH] #include cleanliness

2011-05-31 Thread Anthony Liguori
On 05/30/2011 04:06 AM, Avi Kivity wrote: On 05/30/2011 01:06 AM, Anthony Liguori wrote: On 05/19/2011 09:17 AM, Avi Kivity wrote: My mother always told me to explicitly #include any headers need to compile a file, instead of relying on other #includes to bring them in. This patch fixes up targ

Re: [Qemu-devel] [PATCH] #include cleanliness

2011-05-30 Thread Avi Kivity
On 05/30/2011 01:06 AM, Anthony Liguori wrote: On 05/19/2011 09:17 AM, Avi Kivity wrote: My mother always told me to explicitly #include any headers need to compile a file, instead of relying on other #includes to bring them in. This patch fixes up targphys.h and cpu-common.h in this regard.

Re: [Qemu-devel] [PATCH] #include cleanliness

2011-05-29 Thread Anthony Liguori
On 05/19/2011 09:17 AM, Avi Kivity wrote: My mother always told me to explicitly #include any headers need to compile a file, instead of relying on other #includes to bring them in. This patch fixes up targphys.h and cpu-common.h in this regard. Signed-off-by: Avi Kivity --- cpu-common.h |

Re: [Qemu-devel] [PATCH] #include cleanliness

2011-05-29 Thread Avi Kivity
On 05/19/2011 05:17 PM, Avi Kivity wrote: My mother always told me to explicitly #include any headers need to compile a file, instead of relying on other #includes to bring them in. This patch fixes up targphys.h and cpu-common.h in this regard. Can some qemu maintainer review this patch? Ste

[Qemu-devel] [PATCH] #include cleanliness

2011-05-19 Thread Avi Kivity
My mother always told me to explicitly #include any headers need to compile a file, instead of relying on other #includes to bring them in. This patch fixes up targphys.h and cpu-common.h in this regard. Signed-off-by: Avi Kivity --- cpu-common.h |4 targphys.h |2 ++ 2 files cha