Re: [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks

2013-06-18 Thread Jan Kiszka
On 2013-06-17 13:41, Bas van Sisseren wrote: > On 04/06/13 14:26, Stefan Hajnoczi wrote: >> On Mon, Jun 03, 2013 at 03:11:49PM +0200, Bas van Sisseren wrote: >>> reorder slirp config options. first check the dns-server-address, >>> then check the first-dhcp-address. the original code was comparing

Re: [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks

2013-06-17 Thread Stefan Hajnoczi
On Mon, Jun 17, 2013 at 01:41:40PM +0200, Bas van Sisseren wrote: > On 04/06/13 14:26, Stefan Hajnoczi wrote: > > On Mon, Jun 03, 2013 at 03:11:49PM +0200, Bas van Sisseren wrote: > >> reorder slirp config options. first check the dns-server-address, > >> then check the first-dhcp-address. the orig

Re: [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks

2013-06-17 Thread Bas van Sisseren
On 04/06/13 14:26, Stefan Hajnoczi wrote: > On Mon, Jun 03, 2013 at 03:11:49PM +0200, Bas van Sisseren wrote: >> reorder slirp config options. first check the dns-server-address, >> then check the first-dhcp-address. the original code was comparing >> the first-dhcp-address with the default dns-ser

Re: [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks

2013-06-04 Thread Stefan Hajnoczi
On Mon, Jun 03, 2013 at 03:11:49PM +0200, Bas van Sisseren wrote: > reorder slirp config options. first check the dns-server-address, > then check the first-dhcp-address. the original code was comparing > the first-dhcp-address with the default dns-server-address, not > the configured dns-server-ad

[Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks

2013-06-03 Thread Bas van Sisseren
reorder slirp config options. first check the dns-server-address, then check the first-dhcp-address. the original code was comparing the first-dhcp-address with the default dns-server-address, not the configured dns-server-address. Signed-off-by: Bas van Sisseren --- net/slirp.c | 12 ++---