Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-11-24 Thread Peter Maydell
On 22 November 2011 03:25, Peter Chubb wrote: > Properly implement dual-timer read/write for the sp804 dual timer module. > Based on ARM specs at > http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html > > Signed-off-by: Hans Jang > Signed-off-by: David Mirabito > Signe

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-11-21 Thread Peter Chubb
Properly implement dual-timer read/write for the sp804 dual timer module. Based on ARM specs at http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html Signed-off-by: Hans Jang Signed-off-by: David Mirabito Signed-off-by: Peter Chubb --- hw/arm_timer.c | 41 +

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-11-21 Thread Andreas Färber
Am 21.11.2011 23:05, schrieb Peter Chubb: > Hi Peter, >Here's a fixed patch for the sp804 timer. > > Properly implement the dual-timer read/write for the sp804 dual timer module. > Based on ARM specs at > http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html > > Sign

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-11-21 Thread Peter Chubb
Hi Peter, Here's a fixed patch for the sp804 timer. Properly implement the dual-timer read/write for the sp804 dual timer module. Based on ARM specs at http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html Signed-off-by: Peter Chubb Signed-off-by: David Mirabito Sig

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-09-30 Thread Peter Maydell
On 30 September 2011 10:23, Peter Chubb wrote: >> "Peter" == Peter Maydell writes: > Peter> hw_error() is a fatal error -- don't use it for conditions that > Peter> can be triggered by a malicious guest. (And since it's noreturn > Peter> there's not much point putting any code after it...) >

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-09-30 Thread Peter Chubb
> "Peter" == Peter Maydell writes: Peter> On 30 September 2011 01:20, Peter Chubb Peter> wrote: >> Thanks Peter! >> >> Here's a reworked patch. Peter> NB: when you resend patches it's better to send them as Peter> completely fresh emails (via git-send-email or equivalent) Peter> because ot

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-09-30 Thread Peter Maydell
On 30 September 2011 01:20, Peter Chubb wrote: > Thanks Peter! > > Here's a reworked patch. NB: when you resend patches it's better to send them as completely fresh emails (via git-send-email or equivalent) because otherwise they're more of a pain to apply (you end up with random email chatter in

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-09-29 Thread Peter Chubb
Thanks Peter! Here's a reworked patch. From 7af8e24d6cbd9170a206b6aaac164e3934312b7c Mon Sep 17 00:00:00 2001 From: David Mirabito Date: Fri, 24 Jul 2009 11:43:14 +1000 Subject: [PATCH 53/57] Fix sp804 read/write for second timer. Properly implement the dual-timer read/write for the sp804 dual

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-09-29 Thread Peter Maydell
On 29 September 2011 03:34, Peter Chubb wrote: > -/* ??? Don't know the PrimeCell ID for this device. */ > if (offset < 0x20) { > return arm_timer_read(s->timer[0], offset); > -} else { > +} > +if (offset < 0x40) { > return arm_timer_read(s->timer[1], offset -

[Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-09-28 Thread Peter Chubb
This patch was written by David Mirabito. Properly implement the dual-timer read/write for the sp804 dual timer module. Based on ARM specs at http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html Signed-off-by: Peter Chubb Signed-off-by: David Mirabito Signed-off-by: