Re: [Qemu-devel] [PATCH][Outreachy] Signed-off-by: Sarah Khan

2016-03-04 Thread Peter Maydell
On 4 March 2016 at 16:35, Eric Blake wrote: > On 03/04/2016 09:06 AM, Peter Maydell wrote: > +++ b/thunk.c @@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types) for(i = 0;i < 2; i++) { offset = 0; max_alig

Re: [Qemu-devel] [PATCH][Outreachy] Signed-off-by: Sarah Khan

2016-03-04 Thread Eric Blake
On 03/04/2016 09:06 AM, Peter Maydell wrote: >>> +++ b/thunk.c >>> @@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *name, >>> const argtype *types) >>> for(i = 0;i < 2; i++) { >>> offset = 0; >>> max_align = 1; >>> -se->field_offsets[i] = malloc(nb_f

Re: [Qemu-devel] [PATCH][Outreachy] Signed-off-by: Sarah Khan

2016-03-04 Thread Sarah Khan
Ok. Will complete the required. Thanks, Sarah On 4 March 2016 at 15:44, Eric Blake wrote: > On 03/04/2016 07:53 AM, Sarah Khan wrote: >> This patch replaces malloc() with g_malloc() as stated to be done in bitesized task >> >> diff --git a/thunk.c b/thunk.c >> index f057d86..bddabae 100644 >> ---

Re: [Qemu-devel] [PATCH][Outreachy] Signed-off-by: Sarah Khan

2016-03-04 Thread Peter Maydell
On 4 March 2016 at 15:44, Eric Blake wrote: > On 03/04/2016 07:53 AM, Sarah Khan wrote: >> This patch replaces malloc() with g_malloc() as stated to be done in >> bitesized task >> >> diff --git a/thunk.c b/thunk.c >> index f057d86..bddabae 100644 >> --- a/thunk.c >> +++ b/thunk.c >> @@ -88,7 +88

Re: [Qemu-devel] [PATCH][Outreachy] Signed-off-by: Sarah Khan

2016-03-04 Thread Eric Blake
On 03/04/2016 08:49 AM, Eric Blake wrote: > Oh, I see you DID include a S-o-b, but in the subject line of the patch > instead of the commit body. Which still needs work. You need a > one-line summary as the subject, not your S-o-b, so the commit message > should look more like: > > thunk: Repla

Re: [Qemu-devel] [PATCH][Outreachy] Signed-off-by: Sarah Khan

2016-03-04 Thread Eric Blake
On 03/04/2016 08:44 AM, Eric Blake wrote: > On 03/04/2016 07:53 AM, Sarah Khan wrote: >> This patch replaces malloc() with g_malloc() as stated to be done in >> bitesized task >> >> diff --git a/thunk.c b/thunk.c >> index f057d86..bddabae 100644 >> --- a/thunk.c >> +++ b/thunk.c >> @@ -88,7 +88,7

Re: [Qemu-devel] [PATCH][Outreachy] Signed-off-by: Sarah Khan

2016-03-04 Thread Eric Blake
On 03/04/2016 07:53 AM, Sarah Khan wrote: > This patch replaces malloc() with g_malloc() as stated to be done in > bitesized task > > diff --git a/thunk.c b/thunk.c > index f057d86..bddabae 100644 > --- a/thunk.c > +++ b/thunk.c > @@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *n

[Qemu-devel] [PATCH][Outreachy] Signed-off-by: Sarah Khan

2016-03-04 Thread Sarah Khan
This patch replaces malloc() with g_malloc() as stated to be done in bitesized task diff --git a/thunk.c b/thunk.c index f057d86..bddabae 100644 --- a/thunk.c +++ b/thunk.c @@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types) for(i = 0;i < 2; i++) {