Re: [Qemu-devel] [PATCH]: Fix conditional compilation for OpenBSD

2013-03-31 Thread Peter Maydell
On 31 March 2013 13:46, Michael W. Bombardieri wrote: > What about this? > > Re-use the exting the pthread checker code in 'configure', define HAS_PTHREAD > and use this instead of OS specific #if checks. I have built this on > > 1. Ubuntu 10.04.3 LTS (Linux 2.6.32-36-generic i686) > 2. OpenBSD 5.

Re: [Qemu-devel] [PATCH]: Fix conditional compilation for OpenBSD

2013-03-31 Thread Michael W. Bombardieri
On Sun, Mar 31, 2013 at 12:48:04AM +, Peter Maydell wrote: > > Hi Michael; thanks for the patch. However I think we should > fix this by having a configure check for sem_timedwait [or > whatever the functions we need are], rather than by piling > up another OS ifdef check. > > (If you want to

Re: [Qemu-devel] [PATCH]: Fix conditional compilation for OpenBSD

2013-03-30 Thread Peter Maydell
On 31 March 2013 00:32, Michael W. Bombardieri wrote: > This morning I tried building Qemu 1.4.0 on my > Lenovo ThinkPad T61 running OpenBSD/i386 5.1. > The thread code didn't build due to a missing > library function. Looking at the code, #if > statements for NetBSD should also be followed > for

[Qemu-devel] [PATCH]: Fix conditional compilation for OpenBSD

2013-03-30 Thread Michael W. Bombardieri
Hi, This morning I tried building Qemu 1.4.0 on my Lenovo ThinkPad T61 running OpenBSD/i386 5.1. The thread code didn't build due to a missing library function. Looking at the code, #if statements for NetBSD should also be followed for OpenBSD. Using the following patch I was able to build Qemu us