Re: [Qemu-devel] [PATCH, RFC] mips: fix cpu_reset memory leak

2009-11-13 Thread Aurelien Jarno
On Tue, Nov 10, 2009 at 04:30:59PM +0100, Aurelien Jarno wrote: > On Sun, Nov 08, 2009 at 12:50:21PM +0200, Blue Swirl wrote: > > Both mmu_init() and mvp_init() allocate structures, so call > > cpu_mips_register > > only when creating a CPU. > > > > In addition, maybe some of the some of the fiel

Re: [Qemu-devel] [PATCH, RFC] mips: fix cpu_reset memory leak

2009-11-10 Thread Aurelien Jarno
On Sun, Nov 08, 2009 at 12:50:21PM +0200, Blue Swirl wrote: > Both mmu_init() and mvp_init() allocate structures, so call cpu_mips_register > only when creating a CPU. > > In addition, maybe some of the some of the field initialization stuff > in cpu_mips_register, mmu_init, mvp_init, fpu_init et

[Qemu-devel] [PATCH, RFC] mips: fix cpu_reset memory leak

2009-11-08 Thread Blue Swirl
Both mmu_init() and mvp_init() allocate structures, so call cpu_mips_register only when creating a CPU. In addition, maybe some of the some of the field initialization stuff in cpu_mips_register, mmu_init, mvp_init, fpu_init etc. should be moved to cpu_reset instead, in case the fields should be