Re: [Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

2016-01-22 Thread Sean Bruno
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/22/16 09:02, Daniel P. Berrange wrote: > On Fri, Jan 22, 2016 at 08:52:36AM -0800, Sean Bruno wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 >> >> >> >> On 01/22/16 08:47, Peter Maydell wrote: >> >>> This one is just straightfo

Re: [Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

2016-01-22 Thread Daniel P. Berrange
On Fri, Jan 22, 2016 at 08:52:36AM -0800, Sean Bruno wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > > > On 01/22/16 08:47, Peter Maydell wrote: > > > This one is just straightforwardly BSD-only code that hasn't been > > compile-tested. > > > >> qemu-char.c:4265:36: warning: inc

Re: [Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

2016-01-22 Thread Sean Bruno
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/22/16 08:47, Peter Maydell wrote: > This one is just straightforwardly BSD-only code that hasn't been > compile-tested. > >> qemu-char.c:4265:36: warning: incompatible pointer types passing >> 'ChardevCommon *' (aka 'struct ChardevCommon *

Re: [Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

2016-01-22 Thread Peter Maydell
On 22 January 2016 at 16:39, Sean Bruno wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Started seeing a build failure after the updates to qemu-char.c Ccing Dan whose commit that is... > I think clang is not doing something that gcc does implicitly? > > qemu-char.c:1843:26: error

[Qemu-devel] [FreeBSD] Build Failure, qemu-char.c

2016-01-22 Thread Sean Bruno
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Started seeing a build failure after the updates to qemu-char.c I think clang is not doing something that gcc does implicitly? qemu-char.c:1843:26: error: use of undeclared identifier 'common' chr = qemu_chr_alloc(common, errp);