[FOR 0.12 PATCH] qdev: Improve uni-north device names (was: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace)

2009-12-14 Thread Markus Armbruster
Switch to the names suggested by Blue Swirl. Signed-off-by: Markus Armbruster --- hw/unin_pci.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/unin_pci.c b/hw/unin_pci.c index f07c966..3ae4e7a 100644 --- a/hw/unin_pci.c +++ b/hw/unin_pci.c @@

Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace

2009-12-12 Thread Blue Swirl
On Sat, Dec 12, 2009 at 6:04 PM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Wed, Dec 9, 2009 at 11:43 AM, Markus Armbruster wrote: >>> Ian Molton writes: >>> Markus Armbruster wrote: > The place for verbose device names is DeviceInfo member desc.  The > name should

Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace

2009-12-12 Thread Markus Armbruster
Blue Swirl writes: > On Wed, Dec 9, 2009 at 11:43 AM, Markus Armbruster wrote: >> Ian Molton writes: >> >>> Markus Armbruster wrote: >>> The place for verbose device names is DeviceInfo member desc.  The name should be short & sweet. >>> >>> Agreed, however... >>> >>> Why do these (ma

Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace

2009-12-12 Thread Blue Swirl
On Wed, Dec 9, 2009 at 11:43 AM, Markus Armbruster wrote: > Ian Molton writes: > >> Markus Armbruster wrote: >> >>> The place for verbose device names is DeviceInfo member desc.  The >>> name should be short & sweet. >> >> Agreed, however... >> >> Why do these (maybe others) get caps in their nam

Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace

2009-12-09 Thread Markus Armbruster
Ian Molton writes: > Markus Armbruster wrote: > >> The place for verbose device names is DeviceInfo member desc. The >> name should be short & sweet. > > Agreed, however... > > Why do these (maybe others) get caps in their names? they dont look > right to me, compared to the others with nice nam

Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace

2009-12-09 Thread Ian Molton
Markus Armbruster wrote: > The place for verbose device names is DeviceInfo member desc. The > name should be short & sweet. Agreed, however... Why do these (maybe others) get caps in their names? they dont look right to me, compared to the others with nice names like usb-serial, piix-ide, or c

[Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace

2009-12-08 Thread Markus Armbruster
Device names with whitespace require quoting in the shell and in the monitor. Some of the offenders are also overly long. Some have a more convenient alias, some don't. The place for verbose device names is DeviceInfo member desc. The name should be short & sweet. Signed-off-by: Markus Armbrus