[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2016-05-27 Thread T. Huth
The patch has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=18f49881cf8359e89396aac ... which should be part of QEMU 2.6.0, so let's mark this bug report as fixed. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-18 Thread Thorsten Glaser
Note that mksh is virtually a superset of OpenBSD ksh and accepts this construct, for a quick fix. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1525682 Title: configure: fix POSIX compatibility is

Re: [Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Eric Blake
[adding autoconf, which likes to document shell bugs] On 12/14/2015 04:34 AM, Dmitrij D. Czarkoff wrote: > OK, so I misidentified the issue and screwed up my bug report. > > The shell is pdksh on OpenBSD, and the real issue is with parentheses: > > $ a=1 > $ b=2 > $ echo "${a+($b)}" > ks

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Peter Maydell
The patch to fix this is at: http://patchwork.ozlabs.org/patch/556537/ Unfortunately it has just missed the cutoff to get into 2.5.0 (since it has been present since 2.4.0 and there is a workaround of running "/path/to/bash configure"). We'll put it into the next 2.5.x stable release, though. --

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Dmitrij D. Czarkoff
FWIW this way it is also consistent with other check results reporting, eg. spice. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1525682 Title: configure: fix POSIX compatibility issue Status in Q

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Peter Maydell
Actually it turns out we really shouldn't be using the ${} syntax anyway, because if nettle is not present we end up printing "nettle: no ()" because $nettle is set to "no", not null or unset. So we should just write this out like: if test "$nettle" = "yes"; then echo "nettle$nett

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Peter Maydell
Thanks. I'll send out a patch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1525682 Title: configure: fix POSIX compatibility issue Status in QEMU: New Bug description: When running configur

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Dmitrij D. Czarkoff
It works. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1525682 Title: configure: fix POSIX compatibility issue Status in QEMU: New Bug description: When running configure script from 2.5.0-r

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Peter Maydell
Unfortunately in bash and dash backslash-escaping the brackets results in the backslashes being printed verbatim: $ (a=1 b=2 ; echo "${a+\($b\)}") \(2\) Can you try this syntax with extra quote characters? (It works in bash/dash): (a=1 b=2 ; echo "${a+"($b)"}") (2) -- You received this bug noti

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Dmitrij D. Czarkoff
OK, so I misidentified the issue and screwed up my bug report. The shell is pdksh on OpenBSD, and the real issue is with parentheses: $ a=1 $ b=2 $ echo "${a+($b)}" ksh: ${a+($b)}": bad substitution $ echo "${a+\($b\)}" (2) -- You received this bug notification because you are a mem

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Peter Maydell
In particular, the Signed-off-by: line is critically important -- we cannot apply a patch without one. git blame says this + syntax was originally introduced in commit becaeb726 in July (though at that point the variable name was slightly different: ${gnutls_nettle+($nettle_version)} ). That means

Re: [Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-14 Thread Stefan Hajnoczi
On Sun, Dec 13, 2015 at 06:39:22PM -, Dmitrij D. Czarkoff wrote: > Sorry, wrong patch. > > ** Patch added: "0001-configure-fix-POSIX-compatibility-issue.patch" > > https://bugs.launchpad.net/qemu/+bug/1525682/+attachment/4534158/+files/0001-configure-fix-POSIX-compatibility-issue.patch >

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

2015-12-13 Thread Dmitrij D. Czarkoff
Sorry, wrong patch. ** Patch added: "0001-configure-fix-POSIX-compatibility-issue.patch" https://bugs.launchpad.net/qemu/+bug/1525682/+attachment/4534158/+files/0001-configure-fix-POSIX-compatibility-issue.patch ** Patch removed: "0001-configure-fix-POSIX-compatibility-issue.patch" https: