Re: [Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd

2017-04-27 Thread Paolo Bonzini
On 25/04/2017 14:02, Jason Wang wrote: > > Thanks a lot for the fix. > > Two questions: > > - If virtio_net_set_status() is the only function that may access tx_bh, > it looks like setting tx_waiting to zero is sufficient? I think clearing tx_bh is better anyway, as leaving a dangling pointer

Re: [Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd

2017-04-27 Thread Gonglei (Arei)
: It won't crash if we don't use vhost-net. Thanks, -Gonglei > - Can you post a formal patch for this? > > Thanks > > > From: wangyunjian > > Sent: Monday, April 24, 2017 6:10 PM > > To: qemu-devel@nongnu.org; Michael S. Tsirkin ; 'Jason > Wang

Re: [Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd

2017-04-25 Thread Jason Wang
on that may access tx_bh, it looks like setting tx_waiting to zero is sufficient? - Can you post a formal patch for this? Thanks From: wangyunjian Sent: Monday, April 24, 2017 6:10 PM To: qemu-devel@nongnu.org; Michael S. Tsirkin ; 'Jason Wang' Cc: wangyunjian ; caihe Subject: [Qemu-de

Re: [Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd

2017-04-25 Thread wangyunjian
caihe Subject: [Qemu-devel][BUG] QEMU crashes with dpdk virtio pmd Qemu crashes, with pre-condition: vm xml config with multiqueue, and the vm's driver virtio-net support multi-queue reproduce steps: i. start dpdk testpmd in VM with the virtio nic ii. stop testpmd iii. reboot the VM This c

[Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd

2017-04-24 Thread wangyunjian
Qemu crashes, with pre-condition: vm xml config with multiqueue, and the vm's driver virtio-net support multi-queue reproduce steps: i. start dpdk testpmd in VM with the virtio nic ii. stop testpmd iii. reboot the VM This commit "f9d6dbf0 remove virtio queues if the guest doesn't support multi