Re: [Qemu-devel] [ PATCH ] hpet: recover timer offset correctly

2017-12-20 Thread Pavel Dovgalyuk
> * Pavel Dovgalyuk (dovga...@ispras.ru) wrote: > > > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > > > * Pavel Dovgalyuk (pavel.dovga...@ispras.ru) wrote: > > > > HPET saves its state by calculating the current time and recovers timer > > > > offset using this calculated value. But

Re: [Qemu-devel] [ PATCH ] hpet: recover timer offset correctly

2017-12-20 Thread Dr. David Alan Gilbert
* Pavel Dovgalyuk (dovga...@ispras.ru) wrote: > > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > > * Pavel Dovgalyuk (pavel.dovga...@ispras.ru) wrote: > > > HPET saves its state by calculating the current time and recovers timer > > > offset using this calculated value. But these calcu

Re: [Qemu-devel] [ PATCH ] hpet: recover timer offset correctly

2017-12-20 Thread Pavel Dovgalyuk
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > * Pavel Dovgalyuk (pavel.dovga...@ispras.ru) wrote: > > HPET saves its state by calculating the current time and recovers timer > > offset using this calculated value. But these calculations include > > divisions and multiplications. The

Re: [Qemu-devel] [ PATCH ] hpet: recover timer offset correctly

2017-12-20 Thread Dr. David Alan Gilbert
* Pavel Dovgalyuk (pavel.dovga...@ispras.ru) wrote: > HPET saves its state by calculating the current time and recovers timer > offset using this calculated value. But these calculations include > divisions and multiplications. Therefore the timer state cannot be recovered > precise enough. > This

Re: [Qemu-devel] [ PATCH ] hpet: recover timer offset correctly

2017-12-20 Thread Paolo Bonzini
On 20/12/2017 08:58, Pavel Dovgalyuk wrote: > HPET saves its state by calculating the current time and recovers timer > offset using this calculated value. But these calculations include > divisions and multiplications. Therefore the timer state cannot be recovered > precise enough. > This patch in

[Qemu-devel] [ PATCH ] hpet: recover timer offset correctly

2017-12-19 Thread Pavel Dovgalyuk
HPET saves its state by calculating the current time and recovers timer offset using this calculated value. But these calculations include divisions and multiplications. Therefore the timer state cannot be recovered precise enough. This patch introduces saving of the original value of the offset to