Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-26 Thread Stefan Hajnoczi
On Mon, Feb 25, 2013 at 04:01:42PM +0100, Markus Armbruster wrote: > Jan Kiszka writes: > > > On 2013-02-25 15:37, Jeff Cody wrote: > >> On Mon, Feb 25, 2013 at 03:30:34PM +0100, Markus Armbruster wrote: > >>> Jan Kiszka writes: > >>> > On 2013-02-25 14:05, Jeff Cody wrote: > > On Sun,

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-26 Thread Kevin Wolf
Am 25.02.2013 um 16:01 hat Markus Armbruster geschrieben: > >> The behaviour then would be nop on no medium during commit all. But if > >> you specifically tried to just run commit() on a single device that > >> had no medium, you would receive ENOMEDIUM. That seems logical to me. > > > > I think,

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Markus Armbruster
Jan Kiszka writes: > On 2013-02-25 15:37, Jeff Cody wrote: >> On Mon, Feb 25, 2013 at 03:30:34PM +0100, Markus Armbruster wrote: >>> Jan Kiszka writes: >>> On 2013-02-25 14:05, Jeff Cody wrote: > On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: >> Hi, >> >> I'm se

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Jan Kiszka
On 2013-02-25 15:37, Jeff Cody wrote: > On Mon, Feb 25, 2013 at 03:30:34PM +0100, Markus Armbruster wrote: >> Jan Kiszka writes: >> >>> On 2013-02-25 14:05, Jeff Cody wrote: On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: > Hi, > > I'm seeing this with git head and 1.4

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Jan Kiszka
On 2013-02-25 15:30, Markus Armbruster wrote: > Jan Kiszka writes: > >> On 2013-02-25 14:05, Jeff Cody wrote: >>> On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: Hi, I'm seeing this with git head and 1.4. Apparently, commit on a non-populated medium now generates t

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Jeff Cody
On Mon, Feb 25, 2013 at 03:30:34PM +0100, Markus Armbruster wrote: > Jan Kiszka writes: > > > On 2013-02-25 14:05, Jeff Cody wrote: > >> On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: > >>> Hi, > >>> > >>> I'm seeing this with git head and 1.4. Apparently, commit on a > >>> non-popul

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Markus Armbruster
Jan Kiszka writes: > On 2013-02-25 14:05, Jeff Cody wrote: >> On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: >>> Hi, >>> >>> I'm seeing this with git head and 1.4. Apparently, commit on a >>> non-populated medium now generates this error instead of ignoring it >>> like in the past. A

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Jan Kiszka
On 2013-02-25 14:05, Jeff Cody wrote: > On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: >> Hi, >> >> I'm seeing this with git head and 1.4. Apparently, commit on a >> non-populated medium now generates this error instead of ignoring it >> like in the past. As we stop iterating over the

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Jeff Cody
On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: > Hi, > > I'm seeing this with git head and 1.4. Apparently, commit on a > non-populated medium now generates this error instead of ignoring it > like in the past. As we stop iterating over the block devices while > doing "all", this may

[Qemu-devel] 'commit' error for 'all': No medium found

2013-02-24 Thread Jan Kiszka
Hi, I'm seeing this with git head and 1.4. Apparently, commit on a non-populated medium now generates this error instead of ignoring it like in the past. As we stop iterating over the block devices while doing "all", this may leaving uncommitted data behind. Didn't test, but I suspect 58513bde83