Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-28 Thread Igor Mammedov
On Wed, 27 Jul 2022 13:22:34 +0800 Robert Hoo wrote: > On Thu, 2022-07-21 at 10:58 +0200, Igor Mammedov wrote: > [...] > Thanks Igor for review. > > > > The patch it is too intrusive and my hunch is that it breaks > > > > ABI and needs a bunch of compat knobs to work properly and > > > > that I'd

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-26 Thread Robert Hoo
On Thu, 2022-07-21 at 10:58 +0200, Igor Mammedov wrote: [...] Thanks Igor for review. > > > The patch it is too intrusive and my hunch is that it breaks > > > ABI and needs a bunch of compat knobs to work properly and > > > that I'd like to avoid unless there is not other way around > > > the probl

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-21 Thread Igor Mammedov
On Fri, 01 Jul 2022 17:23:04 +0800 Robert Hoo wrote: > On Thu, 2022-06-16 at 14:32 +0200, Igor Mammedov wrote: > > On Mon, 30 May 2022 11:40:45 +0800 > > Robert Hoo wrote: > > > > > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, > > > which > > > depricates corresponding _D

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-19 Thread Michael S. Tsirkin
On Tue, Jul 19, 2022 at 10:46:38AM +0800, Robert Hoo wrote: > Ping... Igor could you respond? It's been 3 weeks ...

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-18 Thread Robert Hoo
Ping... On Fri, 2022-07-01 at 17:23 +0800, Robert Hoo wrote: > On Thu, 2022-06-16 at 14:32 +0200, Igor Mammedov wrote: > > On Mon, 30 May 2022 11:40:45 +0800 > > Robert Hoo wrote: > > > > > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, > > > which > > > depricates correspondin

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-01 Thread Robert Hoo
On Thu, 2022-06-16 at 14:32 +0200, Igor Mammedov wrote: > On Mon, 30 May 2022 11:40:45 +0800 > Robert Hoo wrote: > > > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, > > which > > depricates corresponding _DSM Functions defined by PMEM _DSM > > Interface spec > > [2]. > > > >

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-06-16 Thread Igor Mammedov
On Mon, 30 May 2022 11:40:45 +0800 Robert Hoo wrote: > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, which > depricates corresponding _DSM Functions defined by PMEM _DSM Interface spec > [2]. > > In this implementation, we do 2 things > 1. Generalize the QEMU<->ACPI BIOS NVDI

[QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-05-29 Thread Robert Hoo
Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, which depricates corresponding _DSM Functions defined by PMEM _DSM Interface spec [2]. In this implementation, we do 2 things 1. Generalize the QEMU<->ACPI BIOS NVDIMM interface, wrap it with ACPI method dispatch, _DSM is one of the