Re: [PULL v2 38/45] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-09-12 Thread Daniel Henrique Barboza
On 9/12/23 03:05, Michael Tokarev wrote: 12.09.2023 00:43, Daniel Henrique Barboza: On 9/11/23 16:54, Michael Tokarev wrote: ...   /* KVM AIA only has one APLIC instance */ -    if (virt_use_kvm_aia(s)) { +    if (kvm_enabled() && virt_use_kvm_aia(s)) {   create_fdt_socket_aplic

Re: [PULL v2 38/45] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-09-12 Thread Andrew Jones
On Tue, Sep 12, 2023 at 09:05:41AM +0300, Michael Tokarev wrote: > 12.09.2023 00:43, Daniel Henrique Barboza: > > On 9/11/23 16:54, Michael Tokarev wrote: > ... > > > >   /* KVM AIA only has one APLIC instance */ > > > > -    if (virt_use_kvm_aia(s)) { > > > > +    if (kvm_enabled() && virt_use

Re: [PULL v2 38/45] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-09-11 Thread Michael Tokarev
12.09.2023 00:43, Daniel Henrique Barboza: On 9/11/23 16:54, Michael Tokarev wrote: ...   /* KVM AIA only has one APLIC instance */ -    if (virt_use_kvm_aia(s)) { +    if (kvm_enabled() && virt_use_kvm_aia(s)) {   create_fdt_socket_aplic(s, memmap, 0, ... As has been discovered e

Re: [PULL v2 38/45] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-09-11 Thread Daniel Henrique Barboza
On 9/11/23 16:54, Michael Tokarev wrote: 11.09.2023 09:43, Alistair Francis: From: Daniel Henrique Barboza A build with --enable-debug and without KVM will fail as follows: /usr/bin/ld: libqemu-riscv64-softmmu.fa.p/hw_riscv_virt.c.o: in function `virt_machine_init': ./qemu/build/../hw/ris

Re: [PULL v2 38/45] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-09-11 Thread Michael Tokarev
11.09.2023 09:43, Alistair Francis: From: Daniel Henrique Barboza A build with --enable-debug and without KVM will fail as follows: /usr/bin/ld: libqemu-riscv64-softmmu.fa.p/hw_riscv_virt.c.o: in function `virt_machine_init': ./qemu/build/../hw/riscv/virt.c:1465: undefined reference to `kvm_

[PULL v2 38/45] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-09-10 Thread Alistair Francis
From: Daniel Henrique Barboza A build with --enable-debug and without KVM will fail as follows: /usr/bin/ld: libqemu-riscv64-softmmu.fa.p/hw_riscv_virt.c.o: in function `virt_machine_init': ./qemu/build/../hw/riscv/virt.c:1465: undefined reference to `kvm_riscv_aia_create' This happens becaus