Re: [PULL v2 17/61] virtio-snd: check for invalid param shift operands

2024-08-02 Thread Manos Pitsidianakis
On Fri, 02 Aug 2024 08:03, Volker Rümelin wrote: Am 01.08.24 um 10:22 schrieb Michael S. Tsirkin: On Sat, Jul 27, 2024 at 08:55:10AM +0200, Volker Rümelin wrote: Hi Manos, this patch doesn't work as intended. I guess you wanted to write     if (params->format >= sizeof(supported_formats

Re: [PULL v2 17/61] virtio-snd: check for invalid param shift operands

2024-08-01 Thread Volker Rümelin
Am 01.08.24 um 10:22 schrieb Michael S. Tsirkin: > On Sat, Jul 27, 2024 at 08:55:10AM +0200, Volker Rümelin wrote: >>> From: Manos Pitsidianakis >>> >>> When setting the parameters of a PCM stream, we compute the bit flag >>> with the format and rate values as shift operand to check if they are >>

Re: [PULL v2 17/61] virtio-snd: check for invalid param shift operands

2024-08-01 Thread Michael S. Tsirkin
On Sat, Jul 27, 2024 at 08:55:10AM +0200, Volker Rümelin wrote: > > From: Manos Pitsidianakis > > > > When setting the parameters of a PCM stream, we compute the bit flag > > with the format and rate values as shift operand to check if they are > > set in supported_formats and supported_rates. > >

Re: [PULL v2 17/61] virtio-snd: check for invalid param shift operands

2024-07-26 Thread Volker Rümelin
> From: Manos Pitsidianakis > > When setting the parameters of a PCM stream, we compute the bit flag > with the format and rate values as shift operand to check if they are > set in supported_formats and supported_rates. > > If the guest provides a format/rate value which when shifting 1 results >

[PULL v2 17/61] virtio-snd: check for invalid param shift operands

2024-07-23 Thread Michael S. Tsirkin
From: Manos Pitsidianakis When setting the parameters of a PCM stream, we compute the bit flag with the format and rate values as shift operand to check if they are set in supported_formats and supported_rates. If the guest provides a format/rate value which when shifting 1 results in a value bi