Re: [PULL 24/30] spapr_pci: populate ibm,loc-code

2021-08-17 Thread Philippe Mathieu-Daudé
On 8/16/21 6:37 AM, David Gibson wrote: > From 705a10b1cfbe6bcdde37f37f3548845970dc4986 Mon Sep 17 00:00:00 2001 > From: David Gibson > Date: Tue, 10 Aug 2021 14:28:19 +1000 > Subject: [PATCH] spapr_pci: Fix leak in spapr_phb_vfio_get_loc_code() with > g_autofree > MIME-Version: 1.0 > Content-Ty

Re: [PULL 24/30] spapr_pci: populate ibm,loc-code

2021-08-16 Thread David Gibson
On Mon, Aug 16, 2021 at 10:07:12AM +0100, Peter Maydell wrote: > On Mon, 16 Aug 2021 at 06:41, David Gibson > wrote: > > > > Indeed. Revised version below. I'll only attempt to push this to 6.1 > > if we're going to rc4 for other reasons though. > > We are doing an rc4, but I don't think we re

Re: [PULL 24/30] spapr_pci: populate ibm,loc-code

2021-08-16 Thread Peter Maydell
On Mon, 16 Aug 2021 at 06:41, David Gibson wrote: > > Indeed. Revised version below. I'll only attempt to push this to 6.1 > if we're going to rc4 for other reasons though. We are doing an rc4, but I don't think we really need this in 6.1, given that the original leak only happens on a very rar

Re: [PULL 24/30] spapr_pci: populate ibm,loc-code

2021-08-15 Thread David Gibson
On Sun, Aug 15, 2021 at 04:36:18PM +0200, Philippe Mathieu-Daudé wrote: > On 8/13/21 5:17 PM, Peter Maydell wrote: > > On Tue, 10 Aug 2021 at 05:40, David Gibson > > wrote: > >> > >> On Mon, Aug 09, 2021 at 10:57:00AM +0100, Peter Maydell wrote: > >>> > >>> Cleanest fix would be to declare 'path'

Re: [PULL 24/30] spapr_pci: populate ibm,loc-code

2021-08-15 Thread Philippe Mathieu-Daudé
On 8/13/21 5:17 PM, Peter Maydell wrote: > On Tue, 10 Aug 2021 at 05:40, David Gibson > wrote: >> >> On Mon, Aug 09, 2021 at 10:57:00AM +0100, Peter Maydell wrote: >>> >>> Cleanest fix would be to declare 'path' and 'host' as >>>g_autofree char *path = NULL; >>>g_autofree char *host = NUL

Re: [PULL 24/30] spapr_pci: populate ibm,loc-code

2021-08-13 Thread Peter Maydell
On Tue, 10 Aug 2021 at 05:40, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:57:00AM +0100, Peter Maydell wrote: > > > > Cleanest fix would be to declare 'path' and 'host' as > >g_autofree char *path = NULL; > >g_autofree char *host = NULL; > > and then you can remove all the manual g_

Re: [PULL 24/30] spapr_pci: populate ibm,loc-code

2021-08-09 Thread Philippe Mathieu-Daudé
On 8/10/21 6:29 AM, David Gibson wrote: > On Mon, Aug 09, 2021 at 10:57:00AM +0100, Peter Maydell wrote: >> On Tue, 7 Jul 2015 at 16:49, Alexander Graf wrote: >>> >>> From: Nikunj A Dadhania >>> >>> Each hardware instance has a platform unique location code. The OF >>> device tree that describes

Re: [PULL 24/30] spapr_pci: populate ibm,loc-code

2021-08-09 Thread David Gibson
On Mon, Aug 09, 2021 at 10:57:00AM +0100, Peter Maydell wrote: > On Tue, 7 Jul 2015 at 16:49, Alexander Graf wrote: > > > > From: Nikunj A Dadhania > > > > Each hardware instance has a platform unique location code. The OF > > device tree that describes a part of a hardware entity must include >

Re: [PULL 24/30] spapr_pci: populate ibm,loc-code

2021-08-09 Thread Peter Maydell
On Tue, 7 Jul 2015 at 16:49, Alexander Graf wrote: > > From: Nikunj A Dadhania > > Each hardware instance has a platform unique location code. The OF > device tree that describes a part of a hardware entity must include > the “ibm,loc-code” property with a value that represents the location > co

[Qemu-devel] [PULL 24/30] spapr_pci: populate ibm,loc-code

2015-07-07 Thread Alexander Graf
From: Nikunj A Dadhania Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate ibm,loc-code. 1) PCI pass