Re: [PULL 11/13] virtio-gpu: Handle resource blob commands

2024-11-04 Thread BALATON Zoltan
On Mon, 4 Nov 2024, Alex Bennée wrote: Dmitry Osipenko writes: On 11/1/24 20:16, Alex Bennée wrote: Also what is the subtlety behind using both stride and bytes_pp in the calculation. My naive thought would be: fb.bytes_pp * ss.r.width == fb.stride Can anyone enlighten me? GPUs want ima

Re: [PULL 11/13] virtio-gpu: Handle resource blob commands

2024-11-04 Thread Alex Bennée
Dmitry Osipenko writes: > On 11/1/24 20:16, Alex Bennée wrote: >> Also what is the subtlety behind using both stride and bytes_pp in the >> calculation. My naive thought would be: >> >> fb.bytes_pp * ss.r.width == fb.stride >> >> Can anyone enlighten me? > > GPUs want image line size to be al

Re: [PULL 11/13] virtio-gpu: Handle resource blob commands

2024-11-01 Thread Dmitry Osipenko
On 11/1/24 20:16, Alex Bennée wrote: > Also what is the subtlety behind using both stride and bytes_pp in the > calculation. My naive thought would be: > > fb.bytes_pp * ss.r.width == fb.stride > > Can anyone enlighten me? GPUs want image line size to be aligned to a power of 2 value, like 64

Re: [PULL 11/13] virtio-gpu: Handle resource blob commands

2024-11-01 Thread Alex Bennée
Dmitry Osipenko writes: > On 11/1/24 18:35, Peter Maydell wrote: >> On Tue, 29 Oct 2024 at 12:11, Alex Bennée wrote: >>> >>> From: Robert Beckett >>> >>> Support BLOB resources creation, mapping, unmapping and set-scanout by >>> calling the new stable virglrenderer 0.10 interface. Only enabled

Re: [PULL 11/13] virtio-gpu: Handle resource blob commands

2024-11-01 Thread Alex Bennée
Peter Maydell writes: > On Tue, 29 Oct 2024 at 12:11, Alex Bennée wrote: >> >> From: Robert Beckett >> >> Support BLOB resources creation, mapping, unmapping and set-scanout by >> calling the new stable virglrenderer 0.10 interface. Only enabled when >> available and via the blob config. E.g. -

Re: [PULL 11/13] virtio-gpu: Handle resource blob commands

2024-11-01 Thread Dmitry Osipenko
On 11/1/24 18:35, Peter Maydell wrote: > On Tue, 29 Oct 2024 at 12:11, Alex Bennée wrote: >> >> From: Robert Beckett >> >> Support BLOB resources creation, mapping, unmapping and set-scanout by >> calling the new stable virglrenderer 0.10 interface. Only enabled when >> available and via the blob

Re: [PULL 11/13] virtio-gpu: Handle resource blob commands

2024-11-01 Thread Peter Maydell
On Tue, 29 Oct 2024 at 12:11, Alex Bennée wrote: > > From: Robert Beckett > > Support BLOB resources creation, mapping, unmapping and set-scanout by > calling the new stable virglrenderer 0.10 interface. Only enabled when > available and via the blob config. E.g. -device virtio-vga-gl,blob=true >

[PULL 11/13] virtio-gpu: Handle resource blob commands

2024-10-29 Thread Alex Bennée
From: Robert Beckett Support BLOB resources creation, mapping, unmapping and set-scanout by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano Signed-off-by: Robert Becket