Re: [PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-07-13 Thread Eduardo Habkost
On Mon, Jul 13, 2020 at 04:16:50PM +0200, Philippe Mathieu-Daudé wrote: > On 7/13/20 3:57 PM, John Snow wrote: > > On 7/11/20 12:15 PM, Robert Foley wrote: > >> Hi, > >> Thanks for the detailed feedback! I will look at making these changes. > >> > > > > Sorry that it came so late ... > > I was

Re: [PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/13/20 3:57 PM, John Snow wrote: > On 7/11/20 12:15 PM, Robert Foley wrote: >> Hi, >> Thanks for the detailed feedback! I will look at making these changes. >> > > Sorry that it came so late ... I was looking for the patch that makes the python-next series rebase to fail and now I see your c

Re: [PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-07-13 Thread John Snow
On 7/11/20 12:15 PM, Robert Foley wrote: > Hi, > Thanks for the detailed feedback! I will look at making these changes. > Sorry that it came so late ... > On Fri, 10 Jul 2020 at 15:20, John Snow wrote: >> >> >> >> On 7/7/20 3:08 AM, Alex Bennée wrote: >>> From: Robert Foley >>> >> > >>> +

Re: [PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-07-11 Thread Alex Bennée
Robert Foley writes: > Hi, > Thanks for the detailed feedback! I will look at making these > changes. In the interest of getting the CI green I've submitted v2 as is but I'll roll up Robert's cleanups in my rc0 series (which is hopefully a lot smaller!). -- Alex Bennée

Re: [PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-07-11 Thread Robert Foley
Hi, Thanks for the detailed feedback! I will look at making these changes. On Fri, 10 Jul 2020 at 15:20, John Snow wrote: > > > > On 7/7/20 3:08 AM, Alex Bennée wrote: > > From: Robert Foley > > > > > +def recv(self, n=1, sleep_delay_s=0.1): > > +"""Return chars from in memory buff

Re: [PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-07-10 Thread John Snow
On 7/7/20 3:08 AM, Alex Bennée wrote: > From: Robert Foley > Hi, this creates some pylint regressions, can they please be addressed first? > We add the ConsoleSocket object, which has a socket interface > and which will consume all arriving characters on the > socket, placing them into an in

[PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-07-07 Thread Alex Bennée
From: Robert Foley We add the ConsoleSocket object, which has a socket interface and which will consume all arriving characters on the socket, placing them into an in memory buffer. This will also provide those chars via recv() as would a regular socket. ConsoleSocket also has the option of dumpi