Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Mattias Nissler
On Mon, Sep 16, 2024 at 3:06 PM Cédric Le Goater wrote: > > On 9/16/24 14:41, Mattias Nissler wrote: > > Thanks Cédric, I can reproduce now, and my proposed patch fixes avoids > > the crash as expected. > disk images for macos9 and macosx10 all boot. Thanks for testing, happy to hear! I will go

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Cédric Le Goater
On 9/16/24 14:41, Mattias Nissler wrote: Thanks Cédric, I can reproduce now, and my proposed patch fixes avoids the crash as expected. disk images for macos9 and macosx10 all boot. C.

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Mattias Nissler
On Mon, Sep 16, 2024 at 2:28 PM Peter Maydell wrote: > > On Mon, 16 Sept 2024 at 13:14, Mark Cave-Ayland > wrote: > > > > On 16/09/2024 12:44, Peter Maydell wrote: > > > > > On Mon, 16 Sept 2024 at 12:29, Mark Cave-Ayland > > > wrote: > > >> I'm fairly sure that this patch would break MacOS 9 wh

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Mattias Nissler
Thanks Cédric, I can reproduce now, and my proposed patch fixes avoids the crash as expected. On Mon, Sep 16, 2024 at 2:28 PM Cédric Le Goater wrote: > > Mattias, > > > > Cédric, can you try with the above patch and/or > > > > crash seems gone. > > > >> share more details of your setup so I can v

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Cédric Le Goater
Mattias, Cédric, can you try with the above patch and/or crash seems gone. share more details of your setup so I can verify You will need a Linnux powerpc or powerpc64 image for mac machines, which are not common now days, or MacOS images. My debian images are big. I will try to build you

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Peter Maydell
On Mon, 16 Sept 2024 at 13:14, Mark Cave-Ayland wrote: > > On 16/09/2024 12:44, Peter Maydell wrote: > > > On Mon, 16 Sept 2024 at 12:29, Mark Cave-Ayland > > wrote: > >> I'm fairly sure that this patch would break MacOS 9 which was the reason > >> that > >> dma_memory_unmap() was added here in

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Mark Cave-Ayland
On 16/09/2024 12:44, Peter Maydell wrote: On Mon, 16 Sept 2024 at 12:29, Mark Cave-Ayland wrote: On 16/09/2024 09:23, Mattias Nissler wrote: Looking at the code, the dma_memory_unmap calls in hw/ide/macio.c seem to be passing buffer=NULL unconditionally, since the dma_mem field in struct DBD

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Cédric Le Goater
On 9/16/24 10:23, Mattias Nissler wrote: Thanks for the report, and my apologies for the breakage. On Fri, Sep 13, 2024 at 4:47 PM Peter Xu wrote: On Fri, Sep 13, 2024 at 04:35:32PM +0200, Cédric Le Goater wrote: Hello, +Mark (for the Mac devices) On 9/9/24 22:11, Peter Xu wrote: From: Ma

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Peter Maydell
On Mon, 16 Sept 2024 at 12:29, Mark Cave-Ayland wrote: > > On 16/09/2024 09:23, Mattias Nissler wrote: > > Looking at the code, the dma_memory_unmap calls in hw/ide/macio.c seem > > to be passing buffer=NULL unconditionally, since the dma_mem field in > > struct DBDMA_io is never set to anything n

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Mark Cave-Ayland
On 16/09/2024 09:23, Mattias Nissler wrote: Thanks for the report, and my apologies for the breakage. On Fri, Sep 13, 2024 at 4:47 PM Peter Xu wrote: On Fri, Sep 13, 2024 at 04:35:32PM +0200, Cédric Le Goater wrote: Hello, +Mark (for the Mac devices) On 9/9/24 22:11, Peter Xu wrote: From

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-16 Thread Mattias Nissler
Thanks for the report, and my apologies for the breakage. On Fri, Sep 13, 2024 at 4:47 PM Peter Xu wrote: > > On Fri, Sep 13, 2024 at 04:35:32PM +0200, Cédric Le Goater wrote: > > Hello, > > > > +Mark (for the Mac devices) > > > > On 9/9/24 22:11, Peter Xu wrote: > > > From: Mattias Nissler > >

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-13 Thread Peter Xu
On Fri, Sep 13, 2024 at 04:35:32PM +0200, Cédric Le Goater wrote: > Hello, > > +Mark (for the Mac devices) > > On 9/9/24 22:11, Peter Xu wrote: > > From: Mattias Nissler > > > > When DMA memory can't be directly accessed, as is the case when > > running the device model in a separate process wi

Re: [PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-13 Thread Cédric Le Goater
Hello, +Mark (for the Mac devices) On 9/9/24 22:11, Peter Xu wrote: From: Mattias Nissler When DMA memory can't be directly accessed, as is the case when running the device model in a separate process without shareable DMA file descriptors, bounce buffering is used. It is not uncommon for de

[PULL 1/9] softmmu: Support concurrent bounce buffers

2024-09-09 Thread Peter Xu
From: Mattias Nissler When DMA memory can't be directly accessed, as is the case when running the device model in a separate process without shareable DMA file descriptors, bounce buffering is used. It is not uncommon for device models to request mapping of several DMA regions at the same time.