Re: [PULL 1/1] virtio-pci: fix use of a released vector

2024-04-16 Thread Peter Maydell
On Tue, 16 Apr 2024 at 14:06, Cindy Lu wrote: > > On Tue, Apr 16, 2024 at 8:22 PM Peter Maydell > wrote: > > Paolo's comment on CID 1468940 was to suggest "virtio_queue_vector > > should check VIRTIO_CONFIG_IRQ_IDX just like virtio_pci_get_notifier", > > incidentally. > > > Hi peter, > Really so

Re: [PULL 1/1] virtio-pci: fix use of a released vector

2024-04-16 Thread Cindy Lu
On Tue, Apr 16, 2024 at 8:22 PM Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 12:50, Peter Maydell wrote: > > > > On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote: > > > > > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell > > > wrote: > > > > Hi; Coverity points out what it thinks is a problem i

Re: [PULL 1/1] virtio-pci: fix use of a released vector

2024-04-16 Thread Cindy Lu
On Tue, Apr 16, 2024 at 7:50 PM Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote: > > > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell > > wrote: > > > Here we pass that through to kvm_virtio_pci_vector_use_one(). > > > In kvm_virtio_pci_vector_use_one()'s error-exit path

Re: [PULL 1/1] virtio-pci: fix use of a released vector

2024-04-16 Thread Peter Maydell
On Tue, 16 Apr 2024 at 12:50, Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote: > > > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell > > wrote: > > > Hi; Coverity points out what it thinks is a problem in > > > this commit (CID 1543938): > > > Here we pass that through to

Re: [PULL 1/1] virtio-pci: fix use of a released vector

2024-04-16 Thread Peter Maydell
On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote: > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell > wrote: > > Here we pass that through to kvm_virtio_pci_vector_use_one(). > > In kvm_virtio_pci_vector_use_one()'s error-exit path ("undo") > > it does > > vector = virtio_queue_vector(vdev, queu

Re: [PULL 1/1] virtio-pci: fix use of a released vector

2024-04-16 Thread Cindy Lu
On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell wrote: > > On Mon, 15 Apr 2024 at 11:52, Michael S. Tsirkin wrote: > > > > From: Cindy Lu > > > > During the booting process of the non-standard image, the behavior of the > > called function in qemu is as follows: > > > > 1. vhost_net_stop() was tri

Re: [PULL 1/1] virtio-pci: fix use of a released vector

2024-04-16 Thread Peter Maydell
On Mon, 15 Apr 2024 at 11:52, Michael S. Tsirkin wrote: > > From: Cindy Lu > > During the booting process of the non-standard image, the behavior of the > called function in qemu is as follows: > > 1. vhost_net_stop() was triggered by guest image. This will call the function > virtio_pci_set_gues

[PULL 1/1] virtio-pci: fix use of a released vector

2024-04-15 Thread Michael S. Tsirkin
From: Cindy Lu During the booting process of the non-standard image, the behavior of the called function in qemu is as follows: 1. vhost_net_stop() was triggered by guest image. This will call the function virtio_pci_set_guest_notifiers() with assgin= false, virtio_pci_set_guest_notifiers() will