Re: [PULL 02/60] semihosting: Return failure from softmmu-uaccess.h functions

2024-01-29 Thread Philippe Mathieu-Daudé
On 28/6/22 06:53, Richard Henderson wrote: We were reporting unconditional success for these functions; pass on any failure from cpu_memory_rw_debug. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/semihosting/softmmu-uaccess.h | 91 --- 1 fil

Re: [PULL 02/60] semihosting: Return failure from softmmu-uaccess.h functions

2022-07-29 Thread Richard Henderson
On 7/29/22 07:31, Peter Maydell wrote: On Tue, 28 Jun 2022 at 05:54, Richard Henderson wrote: We were reporting unconditional success for these functions; pass on any failure from cpu_memory_rw_debug. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson So, this commit makes us che

Re: [PULL 02/60] semihosting: Return failure from softmmu-uaccess.h functions

2022-07-29 Thread Peter Maydell
On Tue, 28 Jun 2022 at 05:54, Richard Henderson wrote: > > We were reporting unconditional success for these functions; > pass on any failure from cpu_memory_rw_debug. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson So, this commit makes us check the cpu_memory_rw_debug() retu

[PULL 02/60] semihosting: Return failure from softmmu-uaccess.h functions

2022-06-27 Thread Richard Henderson
We were reporting unconditional success for these functions; pass on any failure from cpu_memory_rw_debug. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/semihosting/softmmu-uaccess.h | 91 --- 1 file changed, 39 insertions(+), 52 deletions(-) d