Re: [PULL 02/10] util/interval-tree: Use qatomic_set_mb in rb_link_node

2023-08-04 Thread Michael Tokarev
04.08.2023 16:41, Richard Henderson wrote: On 8/4/23 02:02, Michael Tokarev wrote: 01.08.2023 00:02, Richard Henderson wrote: .. +    qatomic_set_mb(rb_link, node); FWIW, there's no qatomic_set_mb() in 8.0 and before, so this can not be directly applied to stable-8.0.  This commit is missing

Re: [PULL 02/10] util/interval-tree: Use qatomic_set_mb in rb_link_node

2023-08-04 Thread Richard Henderson
On 8/4/23 02:02, Michael Tokarev wrote: 01.08.2023 00:02, Richard Henderson wrote: Ensure that the stores to rb_left and rb_right are complete before inserting the new node into the tree.  Otherwise a concurrent reader could see garbage in the new leaf. Cc: qemu-sta...@nongnu.org Reviewed-by: P

Re: [PULL 02/10] util/interval-tree: Use qatomic_set_mb in rb_link_node

2023-08-04 Thread Michael Tokarev
01.08.2023 00:02, Richard Henderson wrote: Ensure that the stores to rb_left and rb_right are complete before inserting the new node into the tree. Otherwise a concurrent reader could see garbage in the new leaf. Cc: qemu-sta...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Richard Hend

[PULL 02/10] util/interval-tree: Use qatomic_set_mb in rb_link_node

2023-07-31 Thread Richard Henderson
Ensure that the stores to rb_left and rb_right are complete before inserting the new node into the tree. Otherwise a concurrent reader could see garbage in the new leaf. Cc: qemu-sta...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- util/interval-tree.c | 6 +-