Re: [PULL 0/2] Libslirp patches

2021-07-05 Thread Paolo Bonzini
On 08/06/21 17:55, Marc-André Lureau wrote: > I wonder if we miss a dependency like "git-submodule-update: config-host.mak" ? Adding the dependency should work (it doesn't seem to me that it would add any dependency loop). Paolo

Re: [PULL 0/2] Libslirp patches

2021-07-05 Thread Paolo Bonzini
On 05/07/21 18:31, Peter Maydell wrote: 8 here means "8 bytes", not "8 bits". And indeed on i386 you can't do 8-byte atomics with simple insns. You can, there's a cmpxchg8b instruction. The problem is that somehow configure's view of this disagrees with what happens during compilation. If a

Re: [PULL 0/2] Libslirp patches

2021-07-05 Thread Peter Maydell
On Mon, 5 Jul 2021 at 17:25, Stefan Hajnoczi wrote: > > On Mon, Jul 05, 2021 at 12:31:01PM +0200, Philippe Mathieu-Daudé wrote: > > +Richard/Stefan for "atomic" error. > ... > > > [2363/9207] Linking target qemu-system-aarch64 > > > FAILED: qemu-system-aarch64 > > > clang++ @qemu-system-aarch64.rs

Re: [PULL 0/2] Libslirp patches

2021-07-05 Thread Stefan Hajnoczi
On Mon, Jul 05, 2021 at 12:31:01PM +0200, Philippe Mathieu-Daudé wrote: > +Richard/Stefan for "atomic" error. ... > > [2363/9207] Linking target qemu-system-aarch64 > > FAILED: qemu-system-aarch64 > > clang++ @qemu-system-aarch64.rsp > > libqemu-aarch64-softmmu.fa.p/accel_tcg_cputlb.c.o: In functio

Re: [PULL 0/2] Libslirp patches

2021-07-05 Thread Philippe Mathieu-Daudé
+Richard/Stefan for "atomic" error. On 6/8/21 10:35 PM, Marc-André Lureau wrote: > Per subproject `default_library` was added in 0.54, and we require > 0.55.3. Why is it trying to build libslirp.so? > > I tried to make vm-build-ubuntu.i386 with the following changes: > >  diff --git a/tests/vm/

Re: [PULL 0/2] Libslirp patches

2021-06-08 Thread Marc-André Lureau
Hi On Tue, Jun 8, 2021 at 8:55 PM Peter Maydell wrote: > On Tue, 8 Jun 2021 at 16:55, Marc-André Lureau > wrote: > > > > Hi > > > > On Mon, Jun 7, 2021 at 4:17 PM Peter Maydell > wrote: > > >> >> clang sanitizer build: link failure: > >> >> subprojects/libslirp/libslirp.so.0.3.0.p/src_arp_tabl

Re: [PULL 0/2] Libslirp patches

2021-06-08 Thread Peter Maydell
On Tue, 8 Jun 2021 at 16:55, Marc-André Lureau wrote: > > Hi > > On Mon, Jun 7, 2021 at 4:17 PM Peter Maydell wrote: >> >> clang sanitizer build: link failure: >> >> subprojects/libslirp/libslirp.so.0.3.0.p/src_arp_table.c.o: In >> >> function `arp_table_add': >> >> /home/petmay01/linaro/qemu-fo

Re: [PULL 0/2] Libslirp patches

2021-06-08 Thread Marc-André Lureau
Hi On Mon, Jun 7, 2021 at 4:17 PM Peter Maydell wrote: > On Tue, 1 Jun 2021 at 12:01, Marc-André Lureau > wrote: > > > > Hi Peter > > > > On Tue, Jun 1, 2021 at 1:17 PM Peter Maydell > wrote: > >> > >> On Sat, 29 May 2021 at 19:55, wrote: > >> > > >> > From: Marc-André Lureau > >> > > >> > T

Re: [PULL 0/2] Libslirp patches

2021-06-07 Thread Peter Maydell
On Tue, 1 Jun 2021 at 12:01, Marc-André Lureau wrote: > > Hi Peter > > On Tue, Jun 1, 2021 at 1:17 PM Peter Maydell wrote: >> >> On Sat, 29 May 2021 at 19:55, wrote: >> > >> > From: Marc-André Lureau >> > >> > The following changes since commit >> > 62c0ac5041e9130b041adfa13a41583d3c3ddd24: >>

Re: [PULL 0/2] Libslirp patches

2021-06-01 Thread Marc-André Lureau
Hi Peter On Tue, Jun 1, 2021 at 1:17 PM Peter Maydell wrote: > On Sat, 29 May 2021 at 19:55, wrote: > > > > From: Marc-André Lureau > > > > The following changes since commit > 62c0ac5041e9130b041adfa13a41583d3c3ddd24: > > > > Merge remote-tracking branch > 'remotes/rth-gitlab/tags/pull-tcg-

Re: [PULL 0/2] Libslirp patches

2021-06-01 Thread Peter Maydell
On Sat, 29 May 2021 at 19:55, wrote: > > From: Marc-André Lureau > > The following changes since commit 62c0ac5041e9130b041adfa13a41583d3c3ddd24: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210526' > into staging (2021-05-28 16:25:21 +0100) > > are available in the Git

[PULL 0/2] Libslirp patches

2021-05-29 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 62c0ac5041e9130b041adfa13a41583d3c3ddd24: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210526' into staging (2021-05-28 16:25:21 +0100) are available in the Git repository at: g...@github.com:elmarco/qemu.git t