Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-10 Thread Paolo Bonzini
[Sorry Markus, I missed this message before] On 10/10/19 10:16, Markus Armbruster wrote: > I don't think merging this via qemu-trivial is a good idea. First, it's > not sufficiently trivial, as we shall see below. Second, the code in > question has a maintainer willing to review and merge patche

Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-10 Thread Markus Armbruster
I don't think merging this via qemu-trivial is a good idea. First, it's not sufficiently trivial, as we shall see below. Second, the code in question has a maintainer willing to review and merge patches: me. I can't always review as quickly as we all would like; sorry about that. Mario Smarduch

Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-10 Thread Markus Armbruster
Paolo Bonzini writes: > On 09/10/19 18:44, Mario Smarduch wrote: >> }; >> @@ -1263,6 +1267,7 @@ static void realtime_init(void) >> static void configure_msg(QemuOpts *opts) >> { >> enable_timestamp_msg = qemu_opt_get_bool(opts, "timestamp", true); >> +enable_guestname_msg = qemu_opt_g

Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-09 Thread Paolo Bonzini
On 09/10/19 18:44, Mario Smarduch wrote: > }; > @@ -1263,6 +1267,7 @@ static void realtime_init(void) > static void configure_msg(QemuOpts *opts) > { > enable_timestamp_msg = qemu_opt_get_bool(opts, "timestamp", true); > +enable_guestname_msg = qemu_opt_get_bool(opts, "name", false); >

[PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-09 Thread Mario Smarduch
This patch adds an option to enable/disable printing lead guest name in logging messages. A '-msg name=on|off' allows to turn on, off guest name logging. If guest name is not set disabling this makes sense. Verified with all combinations of '-msg timestamp=yes|no,name=yes|no. Signed-off-by: