Re: [PATCH v9 1/9] machine: Use error handling when CPU type is checked

On 1/5/24 21:00, Philippe Mathieu-Daudé wrote: On 4/12/23 01:47, Gavin Shan wrote: Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. The principle is violated by machine_run_board_init() because it calls

Re: [PATCH v9 1/9] machine: Use error handling when CPU type is checked

On 4/12/23 01:47, Gavin Shan wrote: Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. The principle is violated by machine_run_board_init() because it calls error_report(), error_printf(), and exit(1) when

[PATCH v9 1/9] machine: Use error handling when CPU type is checked

Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. The principle is violated by machine_run_board_init() because it calls error_report(), error_printf(), and exit(1) when the machine doesn't support the reque