Re: [PATCH v9 06/17] vfio-user: build library

2022-05-10 Thread Jag Raman
> On May 10, 2022, at 9:22 AM, Daniel P. Berrangé wrote: > > On Thu, May 05, 2022 at 05:17:01PM +0100, Peter Maydell wrote: >> On Thu, 5 May 2022 at 16:44, Stefan Hajnoczi wrote: >>> >>> On Tue, May 03, 2022 at 10:16:47AM -0400, Jagannathan Raman wrote: >>> Ubuntu 20.04LTS has CMake 3.16.3: >

Re: [PATCH v9 06/17] vfio-user: build library

2022-05-10 Thread Daniel P . Berrangé
On Thu, May 05, 2022 at 05:17:01PM +0100, Peter Maydell wrote: > On Thu, 5 May 2022 at 16:44, Stefan Hajnoczi wrote: > > > > On Tue, May 03, 2022 at 10:16:47AM -0400, Jagannathan Raman wrote: > > Ubuntu 20.04LTS has CMake 3.16.3: > > https://packages.ubuntu.com/focal/cmake > > > > That does not me

Re: [PATCH v9 06/17] vfio-user: build library

2022-05-05 Thread Peter Maydell
On Thu, 5 May 2022 at 16:44, Stefan Hajnoczi wrote: > > On Tue, May 03, 2022 at 10:16:47AM -0400, Jagannathan Raman wrote: > Ubuntu 20.04LTS has CMake 3.16.3: > https://packages.ubuntu.com/focal/cmake > > That does not meet the minimum version requirement in this patch series > (3.19.0). > > Pleas

Re: [PATCH v9 06/17] vfio-user: build library

2022-05-05 Thread Daniel P . Berrangé
On Thu, May 05, 2022 at 04:39:35PM +0100, Stefan Hajnoczi wrote: > On Tue, May 03, 2022 at 10:16:47AM -0400, Jagannathan Raman wrote: > > diff --git a/subprojects/libvfio-user b/subprojects/libvfio-user > > new file mode 16 > > index 00..030d2f6e79 > > --- /dev/null > > +++ b/subproject

Re: [PATCH v9 06/17] vfio-user: build library

2022-05-05 Thread Stefan Hajnoczi
On Tue, May 03, 2022 at 10:16:47AM -0400, Jagannathan Raman wrote: > diff --git a/subprojects/libvfio-user b/subprojects/libvfio-user > new file mode 16 > index 00..030d2f6e79 > --- /dev/null > +++ b/subprojects/libvfio-user > @@ -0,0 +1 @@ > +Subproject commit 030d2f6e7978b8ca7577b81d4

[PATCH v9 06/17] vfio-user: build library

2022-05-03 Thread Jagannathan Raman
add the libvfio-user library as a submodule. build it as a cmake subproject. libvfio-user is distributed with BSD 3-Clause license and json-c with MIT (Expat) license Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi ---