Re: [PATCH v8 40/62] target/riscv: vector floating-point compare instructions

2020-06-04 Thread LIU Zhiwei
On 2020/6/5 4:51, Richard Henderson wrote: On 5/21/20 2:43 AM, LIU Zhiwei wrote: +static uint8_t float16_eq_quiet(uint16_t a, uint16_t b, float_status *s) Return bool, better than uint8_t. Yes. +{ +int compare = float16_compare_quiet(a, b, s); New since your last revision is that co

Re: [PATCH v8 40/62] target/riscv: vector floating-point compare instructions

2020-06-04 Thread Richard Henderson
On 5/21/20 2:43 AM, LIU Zhiwei wrote: > +static uint8_t float16_eq_quiet(uint16_t a, uint16_t b, float_status *s) Return bool, better than uint8_t. > +{ > +int compare = float16_compare_quiet(a, b, s); New since your last revision is that compare should be type FloatRelation. And similarly

[PATCH v8 40/62] target/riscv: vector floating-point compare instructions

2020-05-21 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis --- target/riscv/helper.h | 37 + target/riscv/insn32.decode | 12 ++ target/riscv/insn_trans/trans_rvv.inc.c | 35 + target/riscv/vector_helper.c| 174 4 files