Re: [PATCH v8 04/21] hmp: drop Error pointer indirection in hmp_handle_error

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote: We don't need Error **, as all callers pass local Error object, which isn't used after the call. Use Error * instead. Good idea. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Dr. David Alan

[PATCH v8 04/21] hmp: drop Error pointer indirection in hmp_handle_error

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
We don't need Error **, as all callers pass local Error object, which isn't used after the call. Use Error * instead. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Dr. David Alan Gilbert Reviewed-by: Markus Armbruster --- include/monitor/hmp.h | 2 +- dump/dump-hmp-cmds.c