Re: [PATCH v8 02/12] Add virtio-sound-pci device

2023-09-06 Thread Mark Cave-Ayland
On 28/08/2023 20:54, Emmanouil Pitsidianakis wrote: Hi Emmanouil, This patch adds a PCI wrapper device for the virtio-sound device. It is necessary to instantiate a virtio-snd device in a guest. All sound logic will be added to the virtio-snd device in the following commits. To add this device

Re: [PATCH v8 02/12] Add virtio-sound-pci device

2023-09-04 Thread Volker Rümelin
Am 04.09.23 um 12:26 schrieb Manos Pitsidianakis: On Mon, 04 Sep 2023 09:32, Volker Rümelin wrote: +static Property virtio_snd_pci_properties[] = { +    DEFINE_AUDIO_PROPERTIES(VirtIOSoundPCI, vdev.card), I think DEFINE_AUDIO_PROPERTIES should be moved back to virtio-snd.c. The audiodev prop

Re: [PATCH v8 02/12] Add virtio-sound-pci device

2023-09-04 Thread Manos Pitsidianakis
On Mon, 04 Sep 2023 09:32, Volker Rümelin wrote: +static Property virtio_snd_pci_properties[] = { +DEFINE_AUDIO_PROPERTIES(VirtIOSoundPCI, vdev.card), I think DEFINE_AUDIO_PROPERTIES should be moved back to virtio-snd.c. The audiodev property is a virtio-sound property and not a virtio-s

Re: [PATCH v8 02/12] Add virtio-sound-pci device

2023-09-03 Thread Volker Rümelin
This patch adds a PCI wrapper device for the virtio-sound device. It is necessary to instantiate a virtio-snd device in a guest. All sound logic will be added to the virtio-snd device in the following commits. To add this device with a guest, you'll need a >=5.13 kernel compiled with CONFIG_SND_V

[PATCH v8 02/12] Add virtio-sound-pci device

2023-08-28 Thread Emmanouil Pitsidianakis
This patch adds a PCI wrapper device for the virtio-sound device. It is necessary to instantiate a virtio-snd device in a guest. All sound logic will be added to the virtio-snd device in the following commits. To add this device with a guest, you'll need a >=5.13 kernel compiled with CONFIG_SND_VI