Re: [PATCH v8] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-04-03 Thread Volker Rümelin
Hi Dorinda, Hi Volker, Filling a buffer with zeros to produce silence still wrong for unsigned samples. For example, a 0 in SPA_AUDIO_FORMAT_U8 format maps to -1.0 in SPA_AUDIO_FORMAT_F32. This is a bug. On a buffer underrun, the buffer filled with silence is dr

Re: [PATCH v8] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-04-03 Thread Dorinda Bassey
Hi Volker, Filling a buffer with zeros to produce silence still wrong for unsigned > samples. For example, a 0 in SPA_AUDIO_FORMAT_U8 format maps to -1.0 in > SPA_AUDIO_FORMAT_F32. > This is a bug. On a buffer underrun, the buffer filled with silence is > dropped. > What are your suggestions to im

Re: [PATCH v8] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-04-02 Thread Volker Rümelin
Am 28.03.23 um 13:56 schrieb Dorinda Bassey: Hi Dorinda, Hi Volker, Thanks for the feedback. This term is constant for the lifetime of the playback stream. It could be precalculated in qpw_init_out(). It's still constant even when precalculated in qpw_init_out(). It's an optimi

Re: [PATCH v8] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-28 Thread Dorinda Bassey
Hi Volker, Thanks for the feedback. This term is constant for the lifetime of the playback stream. It could > be precalculated in qpw_init_out(). > It's still constant even when precalculated in qpw_init_out(). The if (!v->enabled) block isn't needed. When the guest stops the > playback stream,

Re: [PATCH v8] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-19 Thread Volker Rümelin
diff --git a/audio/trace-events b/audio/trace-events index e1ab643add..e0acf9ac56 100644 --- a/audio/trace-events +++ b/audio/trace-events @@ -18,6 +18,13 @@ dbus_audio_register(const char *s, const char *dir) "sender = %s, dir = %s" dbus_audio_put_buffer_out(size_t len) "len = %zu" dbus_a

Re: [PATCH v8] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-18 Thread Volker Rümelin
Hi Dorinda, This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems Add Pipewire entry points for QEMU Pipewire audio backend Add wrappers for QEMU Pipewire audio backend in qpw_pcm_ops() qpw_write functio

[PATCH v8] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-15 Thread Dorinda Bassey
This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems Add Pipewire entry points for QEMU Pipewire audio backend Add wrappers for QEMU Pipewire audio backend in qpw_pcm_ops() qpw_write function returns the c