Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-27 Thread John Snow
On 5/27/21 1:02 PM, Cleber Rosa wrote: Nipick: - make -C python venv-check ACK, made this change.

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-27 Thread Cleber Rosa
On Tue, May 25, 2021 at 08:24:54PM -0400, John Snow wrote: > Add a python container that contains just enough juice for us to run the > python > code quality analysis tools. > > Base this container on fedora, because fedora has very convenient > packaging for testing multiple python versions. >

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-27 Thread Cleber Rosa
On Thu, May 27, 2021 at 12:17:36PM -0400, Cleber Rosa wrote: > On Wed, May 26, 2021 at 03:56:31PM -0400, John Snow wrote: > > On 5/26/21 2:47 PM, Vladimir Sementsov-Ogievskiy wrote: > > > > build requisite for PyPI packages in the event that PyPI only has a > > > > sdist and not a bdist for a given

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-27 Thread Cleber Rosa
On Wed, May 26, 2021 at 03:56:31PM -0400, John Snow wrote: > On 5/26/21 2:47 PM, Vladimir Sementsov-Ogievskiy wrote: > > > build requisite for PyPI packages in the event that PyPI only has a > > > sdist and not a bdist for a given dependency during installation. > > > > i.e. some packages are comp

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-26 Thread John Snow
On 5/26/21 2:47 PM, Vladimir Sementsov-Ogievskiy wrote: build requisite for PyPI packages in the event that PyPI only has a sdist and not a bdist for a given dependency during installation. i.e. some packages are compiled during installation? Realized I didn't answer this directly. Yes, somet

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-26 Thread John Snow
On 5/26/21 2:47 PM, Vladimir Sementsov-Ogievskiy wrote: Worth leaving the comment somewhere? (not worth any kind of resending of course) Yeah, I'll explain the package selection in the commit message at least. --js

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 21:24, John Snow wrote: On 5/26/21 5:33 AM, Vladimir Sementsov-Ogievskiy wrote: 26.05.2021 03:24, John Snow wrote: Add a python container that contains just enough juice for us to run the python code quality analysis tools. Base this container on fedora, because fedora has very conv

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-26 Thread John Snow
On 5/26/21 5:33 AM, Vladimir Sementsov-Ogievskiy wrote: 26.05.2021 03:24, John Snow wrote: Add a python container that contains just enough juice for us to run the python code quality analysis tools. Base this container on fedora, because fedora has very convenient packaging for testing multip

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-26 Thread John Snow
On 5/26/21 11:32 AM, Alex Bennée wrote: John Snow writes: Add a python container that contains just enough juice for us to run the python code quality analysis tools. Base this container on fedora, because fedora has very convenient packaging for testing multiple python versions. Add two te

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-26 Thread Alex Bennée
John Snow writes: > Add a python container that contains just enough juice for us to run the > python > code quality analysis tools. > > Base this container on fedora, because fedora has very convenient > packaging for testing multiple python versions. > > Add two tests: > > check-python-pipen

Re: [PATCH v7 31/31] gitlab: add python linters to CI

2021-05-26 Thread Vladimir Sementsov-Ogievskiy
26.05.2021 03:24, John Snow wrote: Add a python container that contains just enough juice for us to run the python code quality analysis tools. Base this container on fedora, because fedora has very convenient packaging for testing multiple python versions. Add two tests: check-python-pipenv u

[PATCH v7 31/31] gitlab: add python linters to CI

2021-05-25 Thread John Snow
Add a python container that contains just enough juice for us to run the python code quality analysis tools. Base this container on fedora, because fedora has very convenient packaging for testing multiple python versions. Add two tests: check-python-pipenv uses pipenv to test a frozen, very exp