Re: [PATCH v7 03/13] sev: Remove false abstraction of flash encryption

2021-01-17 Thread David Gibson
On Fri, Jan 15, 2021 at 01:54:25PM +0100, Cornelia Huck wrote: > On Thu, 14 Jan 2021 10:58:01 +1100 > David Gibson wrote: > > > When AMD's SEV memory encryption is in use, flash memory banks (which are > > initialed by pc_system_flash_map()) need to be encrypted with the guest's > > key, so that

Re: [PATCH v7 03/13] sev: Remove false abstraction of flash encryption

2021-01-15 Thread Cornelia Huck
On Thu, 14 Jan 2021 10:58:01 +1100 David Gibson wrote: > When AMD's SEV memory encryption is in use, flash memory banks (which are > initialed by pc_system_flash_map()) need to be encrypted with the guest's > key, so that the guest can read them. > > That's abstracted via the kvm_memcrypt_encryp

[PATCH v7 03/13] sev: Remove false abstraction of flash encryption

2021-01-13 Thread David Gibson
When AMD's SEV memory encryption is in use, flash memory banks (which are initialed by pc_system_flash_map()) need to be encrypted with the guest's key, so that the guest can read them. That's abstracted via the kvm_memcrypt_encrypt_data() callback in the KVM state.. except, that it doesn't really