Re: [PATCH v7 00/14] linux-user: brk fixes

2023-08-03 Thread Helge Deller
On 8/3/23 17:20, Richard Henderson wrote: On 8/3/23 08:01, Helge Deller wrote: If it does, it replaces patches 1,2 & 4-6 from Richard's v7 patch series. The patch you gave below has no overlap with 1,2,4,5 at all. Yes, ignore this Your patch series is fine as-is (the brk()-host-page-

Re: [PATCH v7 00/14] linux-user: brk fixes

2023-08-03 Thread Helge Deller
On 8/3/23 17:11, Richard Henderson wrote: On 8/3/23 08:01, Helge Deller wrote: * Joel Stanley : On Thu, 3 Aug 2023 at 13:55, Helge Deller wrote: 143551 brk(NULL) = 0x0009b000 143551 brk(0x0009b8fc) = 0x0009b000 I think the problem is the brk with 9b000 here. It's not 64k aligned (=pages siz

Re: [PATCH v7 00/14] linux-user: brk fixes

2023-08-03 Thread Richard Henderson
On 8/3/23 08:01, Helge Deller wrote: If it does, it replaces patches 1,2 & 4-6 from Richard's v7 patch series. The patch you gave below has no overlap with 1,2,4,5 at all. r~

Re: [PATCH v7 00/14] linux-user: brk fixes

2023-08-03 Thread Richard Henderson
On 8/3/23 08:01, Helge Deller wrote: * Joel Stanley : On Thu, 3 Aug 2023 at 13:55, Helge Deller wrote: 143551 brk(NULL) = 0x0009b000 143551 brk(0x0009b8fc) = 0x0009b000 I think the problem is the brk with 9b000 here. It's not 64k aligned (=pages size of your ppc64le). Please try with this p

Re: [PATCH v7 00/14] linux-user: brk fixes

2023-08-03 Thread Helge Deller
* Joel Stanley : > On Thu, 3 Aug 2023 at 13:55, Helge Deller wrote: > > > 143551 brk(NULL) = 0x0009b000 > > > 143551 brk(0x0009b8fc) = 0x0009b000 > > > > I think the problem is the brk with 9b000 here. > > It's not 64k aligned (=pages size of your ppc64le). > > > > Please try with this patch on to

Re: [PATCH v7 00/14] linux-user: brk fixes

2023-08-03 Thread Joel Stanley
On Thu, 3 Aug 2023 at 13:55, Helge Deller wrote: > > 143551 brk(NULL) = 0x0009b000 > > 143551 brk(0x0009b8fc) = 0x0009b000 > > I think the problem is the brk with 9b000 here. > It's not 64k aligned (=pages size of your ppc64le). > > Please try with this patch on top of Richard's series: > > > @@ -

Re: [PATCH v7 00/14] linux-user: brk fixes

2023-08-03 Thread Helge Deller
On 8/3/23 15:11, Joel Stanley wrote: Hi Richard, On Thu, 3 Aug 2023 at 01:53, Richard Henderson wrote: Builds on Helge's v6, incorporating my feedback plus some other minor cleanup. This succeeds for the armhf static binary on ppc64le host that was previously segfaulting. However, the arm

Re: [PATCH v7 00/14] linux-user: brk fixes

2023-08-03 Thread Joel Stanley
Hi Richard, On Thu, 3 Aug 2023 at 01:53, Richard Henderson wrote: > > Builds on Helge's v6, incorporating my feedback plus > some other minor cleanup. This succeeds for the armhf static binary on ppc64le host that was previously segfaulting. However, the arm static binary on ppc64le host now se

[PATCH v7 00/14] linux-user: brk fixes

2023-08-02 Thread Richard Henderson
Builds on Helge's v6, incorporating my feedback plus some other minor cleanup. r~ Akihiko Odaki (6): linux-user: Unset MAP_FIXED_NOREPLACE for host linux-user: Fix MAP_FIXED_NOREPLACE on old kernels linux-user: Do not call get_errno() in do_brk() linux-user: Use MAP_FIXED_NOREPLACE for