Re: [PATCH v6 5/9] target/riscv/cpu.c: add priv_spec validate/disable_exts helpers

2023-04-05 Thread Alistair Francis
On Thu, Mar 30, 2023 at 6:11 AM Daniel Henrique Barboza wrote: > > We're doing env->priv_spec validation and assignment at the start of > riscv_cpu_realize(), which is fine, but then we're doing a force disable > on extensions that aren't compatible with the priv version. > > This second step is b

[PATCH v6 5/9] target/riscv/cpu.c: add priv_spec validate/disable_exts helpers

2023-03-29 Thread Daniel Henrique Barboza
We're doing env->priv_spec validation and assignment at the start of riscv_cpu_realize(), which is fine, but then we're doing a force disable on extensions that aren't compatible with the priv version. This second step is being done too early. The disabled extensions might be re-enabled again in r