Re: [PATCH v6 3/3] vhost-user: add shared_object msg

2023-09-06 Thread Philippe Mathieu-Daudé
On 6/9/23 18:18, Albert Esteve wrote: So: - Regarding the two functions with the same, seems to be solved with the squash before,   and it was probably causing the compile error to begin with, so one less thing to worry about! - Regarding splitting the commit, sure, no p

Re: [PATCH v6 3/3] vhost-user: add shared_object msg

2023-09-06 Thread Albert Esteve
On Wed, Sep 6, 2023 at 6:01 PM Albert Esteve wrote: > > > On Wed, Sep 6, 2023 at 4:43 PM Philippe Mathieu-Daudé > wrote: > >> On 6/9/23 16:33, Albert Esteve wrote: >> >> > I note you ignored my comment regarding adding a 'Error **' >> argument in >> > the previous version: >> > >> https

Re: [PATCH v6 3/3] vhost-user: add shared_object msg

2023-09-06 Thread Albert Esteve
On Wed, Sep 6, 2023 at 4:43 PM Philippe Mathieu-Daudé wrote: > On 6/9/23 16:33, Albert Esteve wrote: > > > I note you ignored my comment regarding adding a 'Error **' > argument in > > the previous version: > > > https://lore.kernel.org/qemu-devel/911eef0c-d04f-2fcf-e78b-2475cd7af...@lin

Re: [PATCH v6 3/3] vhost-user: add shared_object msg

2023-09-06 Thread Philippe Mathieu-Daudé
On 6/9/23 16:33, Albert Esteve wrote: I note you  ignored my comment regarding adding a 'Error **' argument in the previous version: https://lore.kernel.org/qemu-devel/911eef0c-d04f-2fcf-e78b-2475cd7af...@linaro.org/

Re: [PATCH v6 3/3] vhost-user: add shared_object msg

2023-09-06 Thread Albert Esteve
On Wed, Sep 6, 2023 at 4:27 PM Philippe Mathieu-Daudé wrote: > Hi Albert, > > On 6/9/23 13:15, Albert Esteve wrote: > > Add three new vhost-user protocol > > `VHOST_USER_BACKEND_SHARED_OBJECT_* messages`. > > These new messages are sent from vhost-user > > back-ends to interact with the virtio-dm

Re: [PATCH v6 3/3] vhost-user: add shared_object msg

2023-09-06 Thread Philippe Mathieu-Daudé
Hi Albert, On 6/9/23 13:15, Albert Esteve wrote: Add three new vhost-user protocol `VHOST_USER_BACKEND_SHARED_OBJECT_* messages`. These new messages are sent from vhost-user back-ends to interact with the virtio-dmabuf table in order to add or remove themselves as virtio exporters, or lookup for

[PATCH v6 3/3] vhost-user: add shared_object msg

2023-09-06 Thread Albert Esteve
Add three new vhost-user protocol `VHOST_USER_BACKEND_SHARED_OBJECT_* messages`. These new messages are sent from vhost-user back-ends to interact with the virtio-dmabuf table in order to add or remove themselves as virtio exporters, or lookup for virtio dma-buf shared objects. The action taken in