Re: [PATCH v6 23/24] migration: Add error-parameterized function variants in VMSD struct

2025-07-21 Thread Akihiko Odaki
On 2025/07/21 22:29, Daniel P. Berrangé wrote: On Mon, Jul 21, 2025 at 10:14:30PM +0900, Akihiko Odaki wrote: On 2025/07/21 20:29, Arun Menon wrote: - We need to have good error reporting in the callbacks in VMStateDescription struct. Specifically pre_save, post_save, pre_load and post_

Re: [PATCH v6 23/24] migration: Add error-parameterized function variants in VMSD struct

2025-07-21 Thread Arun Menon
On Mon, Jul 21, 2025 at 03:05:59PM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 21, 2025 at 07:24:23PM +0530, Arun Menon wrote: > > Hi, > > Thank you for the review. > > > > On Mon, Jul 21, 2025 at 02:32:48PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jul 21, 2025 at 04:59:28PM +0530, Arun M

Re: [PATCH v6 23/24] migration: Add error-parameterized function variants in VMSD struct

2025-07-21 Thread Daniel P . Berrangé
On Mon, Jul 21, 2025 at 07:24:23PM +0530, Arun Menon wrote: > Hi, > Thank you for the review. > > On Mon, Jul 21, 2025 at 02:32:48PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jul 21, 2025 at 04:59:28PM +0530, Arun Menon wrote: > > > - We need to have good error reporting in the callbacks in > >

Re: [PATCH v6 23/24] migration: Add error-parameterized function variants in VMSD struct

2025-07-21 Thread Arun Menon
Hi, Thank you for the review. On Mon, Jul 21, 2025 at 02:32:48PM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 21, 2025 at 04:59:28PM +0530, Arun Menon wrote: > > - We need to have good error reporting in the callbacks in > > VMStateDescription struct. Specifically pre_save, post_save, > > pr

Re: [PATCH v6 23/24] migration: Add error-parameterized function variants in VMSD struct

2025-07-21 Thread Daniel P . Berrangé
On Mon, Jul 21, 2025 at 04:59:28PM +0530, Arun Menon wrote: > - We need to have good error reporting in the callbacks in > VMStateDescription struct. Specifically pre_save, post_save, > pre_load and post_load callbacks. > - It is not possible to change these functions everywhere in one > patc

Re: [PATCH v6 23/24] migration: Add error-parameterized function variants in VMSD struct

2025-07-21 Thread Daniel P . Berrangé
On Mon, Jul 21, 2025 at 10:14:30PM +0900, Akihiko Odaki wrote: > On 2025/07/21 20:29, Arun Menon wrote: > > - We need to have good error reporting in the callbacks in > >VMStateDescription struct. Specifically pre_save, post_save, > >pre_load and post_load callbacks. > > - It is not possibl

Re: [PATCH v6 23/24] migration: Add error-parameterized function variants in VMSD struct

2025-07-21 Thread Akihiko Odaki
On 2025/07/21 20:29, Arun Menon wrote: - We need to have good error reporting in the callbacks in VMStateDescription struct. Specifically pre_save, post_save, pre_load and post_load callbacks. - It is not possible to change these functions everywhere in one patch, therefore, we introduce

[PATCH v6 23/24] migration: Add error-parameterized function variants in VMSD struct

2025-07-21 Thread Arun Menon
- We need to have good error reporting in the callbacks in VMStateDescription struct. Specifically pre_save, post_save, pre_load and post_load callbacks. - It is not possible to change these functions everywhere in one patch, therefore, we introduce a duplicate set of callbacks with Error o