Re: [PATCH v6 14/19] qapi/introspect.py: add type hint annotations

2021-02-18 Thread Markus Armbruster
Markus Armbruster writes: > John Snow writes: > >> NB: The type aliases (SchemaInfo et al) declare intent for some of the >> "dictly-typed" objects we pass around in introspect.py. They do not >> enforce the shape of those objects, and cannot, until Python 3.7 or >> later. (And even then, it may

Re: [PATCH v6 14/19] qapi/introspect.py: add type hint annotations

2021-02-18 Thread Markus Armbruster
John Snow writes: > NB: The type aliases (SchemaInfo et al) declare intent for some of the > "dictly-typed" objects we pass around in introspect.py. They do not > enforce the shape of those objects, and cannot, until Python 3.7 or > later. (And even then, it may not be "worth it".) > > Signed-off

Re: [PATCH v6 14/19] qapi/introspect.py: add type hint annotations

2021-02-17 Thread Markus Armbruster
John Snow writes: > On 2/16/21 11:08 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 2/16/21 3:55 AM, Markus Armbruster wrote: John Snow writes: [...] > diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py > index 353e8020a27..ff16578f6de 100644 > --- a/scr

Re: [PATCH v6 14/19] qapi/introspect.py: add type hint annotations

2021-02-16 Thread John Snow
On 2/16/21 11:08 AM, Markus Armbruster wrote: John Snow writes: On 2/16/21 3:55 AM, Markus Armbruster wrote: John Snow writes: NB: The type aliases (SchemaInfo et al) declare intent for some of the "dictly-typed" objects we pass around in introspect.py. They do not enforce the shape of tho

Re: [PATCH v6 14/19] qapi/introspect.py: add type hint annotations

2021-02-16 Thread Markus Armbruster
John Snow writes: > On 2/16/21 3:55 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> NB: The type aliases (SchemaInfo et al) declare intent for some of the >>> "dictly-typed" objects we pass around in introspect.py. They do not >>> enforce the shape of those objects, and cannot, until P

Re: [PATCH v6 14/19] qapi/introspect.py: add type hint annotations

2021-02-16 Thread John Snow
On 2/16/21 3:55 AM, Markus Armbruster wrote: John Snow writes: NB: The type aliases (SchemaInfo et al) declare intent for some of the "dictly-typed" objects we pass around in introspect.py. They do not enforce the shape of those objects, and cannot, until Python 3.7 or later. (And even then, i

Re: [PATCH v6 14/19] qapi/introspect.py: add type hint annotations

2021-02-16 Thread Markus Armbruster
Markus Armbruster writes: > John Snow writes: > >> NB: The type aliases (SchemaInfo et al) declare intent for some of the >> "dictly-typed" objects we pass around in introspect.py. They do not >> enforce the shape of those objects, and cannot, until Python 3.7 or >> later. (And even then, it may

Re: [PATCH v6 14/19] qapi/introspect.py: add type hint annotations

2021-02-16 Thread Markus Armbruster
John Snow writes: > NB: The type aliases (SchemaInfo et al) declare intent for some of the > "dictly-typed" objects we pass around in introspect.py. They do not > enforce the shape of those objects, and cannot, until Python 3.7 or > later. (And even then, it may not be "worth it".) > > Signed-off

[PATCH v6 14/19] qapi/introspect.py: add type hint annotations

2021-02-15 Thread John Snow
NB: The type aliases (SchemaInfo et al) declare intent for some of the "dictly-typed" objects we pass around in introspect.py. They do not enforce the shape of those objects, and cannot, until Python 3.7 or later. (And even then, it may not be "worth it".) Signed-off-by: John Snow --- scripts/qa