Re: [PATCH v6 1/4] virtio-iommu: Remove set_config callback

2021-11-29 Thread Jean-Philippe Brucker
On Sat, Nov 27, 2021 at 08:29:07AM +0100, Eric Auger wrote: > The spec says "the driver must not write to device configuration > fields". So remove the set_config() callback which anyway did > not do anything. > > Signed-off-by: Eric Auger Removing this makes sense. For bypass, I'll add the func

Re: [PATCH v6 1/4] virtio-iommu: Remove set_config callback

2021-11-26 Thread Eric Auger
Hi, On 11/27/21 8:29 AM, Eric Auger wrote: > The spec says "the driver must not write to device configuration > fields". So remove the set_config() callback which anyway did > not do anything. Forgot to mention that with the advent of  VIRTIO_IOMMU_F_BYPASS_CONFIG feature and bypass field in struct

[PATCH v6 1/4] virtio-iommu: Remove set_config callback

2021-11-26 Thread Eric Auger
The spec says "the driver must not write to device configuration fields". So remove the set_config() callback which anyway did not do anything. Signed-off-by: Eric Auger --- hw/virtio/trace-events | 1 - hw/virtio/virtio-iommu.c | 14 -- 2 files changed, 15 deletions(-) diff --gi