Re: [PATCH v6 1/4] memory: prevent dma-reentracy issues

2023-03-10 Thread Peter Maydell
On Fri, 10 Mar 2023 at 13:29, Alexander Bulekov wrote: > > On 230310 0802, Alexander Bulekov wrote: > > On 230310 1245, Peter Maydell wrote: > > > On Fri, 10 Mar 2023 at 12:32, Alexander Bulekov wrote: > > > > This MR seems to be "lsi-ram". > > > > > > > > From hw/scsi/lsi53c895a.c: > > > > > > >

Re: [PATCH v6 1/4] memory: prevent dma-reentracy issues

2023-03-10 Thread Alexander Bulekov
On 230310 0802, Alexander Bulekov wrote: > On 230310 1245, Peter Maydell wrote: > > On Fri, 10 Mar 2023 at 12:32, Alexander Bulekov wrote: > > > This MR seems to be "lsi-ram". > > > > > > From hw/scsi/lsi53c895a.c: > > > > > > memory_region_init_io(&s->ram_io, OBJECT(s), &lsi_ram_ops, s, > > >

Re: [PATCH v6 1/4] memory: prevent dma-reentracy issues

2023-03-10 Thread Mark Cave-Ayland
On 10/03/2023 12:45, Peter Maydell wrote: On Fri, 10 Mar 2023 at 12:32, Alexander Bulekov wrote: This MR seems to be "lsi-ram". From hw/scsi/lsi53c895a.c: memory_region_init_io(&s->ram_io, OBJECT(s), &lsi_ram_ops, s, "lsi-ram", 0x2000); So the LSI device is reading an LSI "Script"

Re: [PATCH v6 1/4] memory: prevent dma-reentracy issues

2023-03-10 Thread Alexander Bulekov
On 230310 1245, Peter Maydell wrote: > On Fri, 10 Mar 2023 at 12:32, Alexander Bulekov wrote: > > This MR seems to be "lsi-ram". > > > > From hw/scsi/lsi53c895a.c: > > > > memory_region_init_io(&s->ram_io, OBJECT(s), &lsi_ram_ops, s, > > "lsi-ram", 0x2000); > > > > So the LSI device is rea

Re: [PATCH v6 1/4] memory: prevent dma-reentracy issues

2023-03-10 Thread Peter Maydell
On Fri, 10 Mar 2023 at 12:32, Alexander Bulekov wrote: > This MR seems to be "lsi-ram". > > From hw/scsi/lsi53c895a.c: > > memory_region_init_io(&s->ram_io, OBJECT(s), &lsi_ram_ops, s, > "lsi-ram", 0x2000); > > So the LSI device is reading an LSI "Script" from its own IO region.. In > this

Re: [PATCH v6 1/4] memory: prevent dma-reentracy issues

2023-03-10 Thread Alexander Bulekov
On 230310 0723, Alexander Bulekov wrote: > On 230310 1214, Fiona Ebner wrote: > > Am 05.02.23 um 05:07 schrieb Alexander Bulekov: > > > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. > > > This flag is set/checked prior to calling a device's MemoryRegion > > > handlers, an

Re: [PATCH v6 1/4] memory: prevent dma-reentracy issues

2023-03-10 Thread Alexander Bulekov
On 230310 1214, Fiona Ebner wrote: > Am 05.02.23 um 05:07 schrieb Alexander Bulekov: > > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. > > This flag is set/checked prior to calling a device's MemoryRegion > > handlers, and set when device code initiates DMA. The purpose

Re: [PATCH v6 1/4] memory: prevent dma-reentracy issues

2023-03-10 Thread Fiona Ebner
Am 05.02.23 um 05:07 schrieb Alexander Bulekov: > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. > This flag is set/checked prior to calling a device's MemoryRegion > handlers, and set when device code initiates DMA. The purpose of this > flag is to prevent two types of D

[PATCH v6 1/4] memory: prevent dma-reentracy issues

2023-02-04 Thread Alexander Bulekov
Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. This flag is set/checked prior to calling a device's MemoryRegion handlers, and set when device code initiates DMA. The purpose of this flag is to prevent two types of DMA-based reentrancy issues: 1.) mmio -> dma -> mmio cas