Re: [PATCH v6 1/1] qga/linux: Add new api 'guest-network-get-route'

2024-07-21 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Thu, Jun 13, 2024 at 12:28 PM Dehan Meng wrote: > The Route information of the Linux VM needs to be used > by administrators and users when debugging network problems > and troubleshooting. > > Signed-off-by: Dehan Meng > --- > qga/commands-posix.c | 135 +++

Re: [PATCH v6 1/1] qga/linux: Add new api 'guest-network-get-route'

2024-07-19 Thread Konstantin Kostiuk
Hi Eric and Markus, Do you have any comments about QAPI schema? Best Regards, Konstantin Kostiuk. On Wed, Jul 17, 2024 at 4:57 PM Philippe Mathieu-Daudé wrote: > On 13/6/24 13:18, Konstantin Kostiuk wrote: > > CC: Daniel, Philippe > > Having a quick look, no major issue noticed. > > Cc'ing Ma

Re: [PATCH v6 1/1] qga/linux: Add new api 'guest-network-get-route'

2024-07-17 Thread Philippe Mathieu-Daudé
On 13/6/24 13:18, Konstantin Kostiuk wrote: CC: Daniel, Philippe Having a quick look, no major issue noticed. Cc'ing Markus/Eric for QAPI schema. BTW MAINTAINERS likely missing: -- >8 -- diff --git a/MAINTAINERS b/MAINTAINERS index 7d9811458c..af4db698de 100644 --- a/MAINTAINERS +++ b/MAINTA

Re: [PATCH v6 1/1] qga/linux: Add new api 'guest-network-get-route'

2024-06-13 Thread Konstantin Kostiuk
CC: Daniel, Philippe On Thu, Jun 13, 2024 at 12:28 PM Dehan Meng wrote: > The Route information of the Linux VM needs to be used > by administrators and users when debugging network problems > and troubleshooting. > > Signed-off-by: Dehan Meng > --- > qga/commands-posix.c | 135 +++

[PATCH v6 1/1] qga/linux: Add new api 'guest-network-get-route'

2024-06-13 Thread Dehan Meng
The Route information of the Linux VM needs to be used by administrators and users when debugging network problems and troubleshooting. Signed-off-by: Dehan Meng --- qga/commands-posix.c | 135 +++ qga/commands-win32.c | 6 ++ qga/qapi-schema.json | 71