Re: [PATCH v6 05/19] qapi/introspect.py: guard against ifcond/comment misuse

2021-02-17 Thread Markus Armbruster
John Snow writes: > _tree_to_qlit is called recursively on dict values (isolated from their > keys); at such a point in generating output it is too late to apply an > ifcond. Similarly, comments do not necessarily have a "tidy" place they > can be printed in such a circumstance. > > Forbid this u

[PATCH v6 05/19] qapi/introspect.py: guard against ifcond/comment misuse

2021-02-15 Thread John Snow
_tree_to_qlit is called recursively on dict values (isolated from their keys); at such a point in generating output it is too late to apply an ifcond. Similarly, comments do not necessarily have a "tidy" place they can be printed in such a circumstance. Forbid this usage by renaming "suppress_firs