Re: [PATCH v6 04/26] plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb

2021-05-17 Thread Richard Henderson
On 5/16/21 7:53 AM, Philippe Mathieu-Daudé wrote: -op->args[*cb_idx + 1] = tcg_flags; +op->args[*cb_idx + 1] = (*begin_op)->args[*cb_idx + 1]; I don't understand this change, can you explain? This patch drops a mostly-unimplemented feature from plugins, where in theory the registrati

Re: [PATCH v6 04/26] plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb

2021-05-16 Thread Philippe Mathieu-Daudé
Hi Richard, On 5/3/21 1:57 AM, Richard Henderson wrote: > As noted by qemu-plugins.h, enum qemu_plugin_cb_flags is > currently unused -- plugins can neither read nor write > guest registers. > > Signed-off-by: Richard Henderson > --- > accel/tcg/plugin-helpers.h | 1 - > include/qemu/plugin.h

[PATCH v6 04/26] plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb

2021-05-02 Thread Richard Henderson
As noted by qemu-plugins.h, enum qemu_plugin_cb_flags is currently unused -- plugins can neither read nor write guest registers. Signed-off-by: Richard Henderson --- accel/tcg/plugin-helpers.h | 1 - include/qemu/plugin.h | 1 - accel/tcg/plugin-gen.c | 8 plugins/core.c