Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-08-05 Thread Kevin Wolf
Am 05.08.2020 um 09:19 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 04.08.2020 um 14:46 hat Markus Armbruster geschrieben: > >> > diff --git a/monitor/hmp.c b/monitor/hmp.c > >> > index d598dd02bb..f609fcf75b 100644 > >> > --- a/monitor/hmp.c > >> > +++ b/monitor/hmp.c > >> >

Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-08-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 04.08.2020 um 14:46 hat Markus Armbruster geschrieben: >> > diff --git a/monitor/hmp.c b/monitor/hmp.c >> > index d598dd02bb..f609fcf75b 100644 >> > --- a/monitor/hmp.c >> > +++ b/monitor/hmp.c >> > @@ -1301,11 +1301,11 @@ cleanup: >> > static void monitor_read(void *opaq

Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-08-04 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> cur_mon really needs to be coroutine-local as soon as we move monitor >> command handlers to coroutines and let them yield. As a first step, just >> remove all direct accesses to cur_mon so that we can implement this in >> the getter function l

Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-08-04 Thread Kevin Wolf
Am 04.08.2020 um 14:46 hat Markus Armbruster geschrieben: > > diff --git a/monitor/hmp.c b/monitor/hmp.c > > index d598dd02bb..f609fcf75b 100644 > > --- a/monitor/hmp.c > > +++ b/monitor/hmp.c > > @@ -1301,11 +1301,11 @@ cleanup: > > static void monitor_read(void *opaque, const uint8_t *buf, int s

Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-08-04 Thread Markus Armbruster
Kevin Wolf writes: > cur_mon really needs to be coroutine-local as soon as we move monitor > command handlers to coroutines and let them yield. As a first step, just > remove all direct accesses to cur_mon so that we can implement this in > the getter function later. > > Signed-off-by: Kevin Wolf

Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-06-02 Thread Kevin Wolf
Am 28.05.2020 um 20:31 hat Eric Blake geschrieben: > On 5/28/20 10:37 AM, Kevin Wolf wrote: > > cur_mon really needs to be coroutine-local as soon as we move monitor > > command handlers to coroutines and let them yield. As a first step, just > > remove all direct accesses to cur_mon so that we can

Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-05-28 Thread Eric Blake
On 5/28/20 10:37 AM, Kevin Wolf wrote: cur_mon really needs to be coroutine-local as soon as we move monitor command handlers to coroutines and let them yield. As a first step, just remove all direct accesses to cur_mon so that we can implement this in the getter function later. Signed-off-by: K

Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-05-28 Thread Eric Blake
On 5/28/20 10:37 AM, Kevin Wolf wrote: cur_mon really needs to be coroutine-local as soon as we move monitor command handlers to coroutines and let them yield. As a first step, just remove all direct accesses to cur_mon so that we can implement this in the getter function later. Signed-off-by: K

[PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-05-28 Thread Kevin Wolf
cur_mon really needs to be coroutine-local as soon as we move monitor command handlers to coroutines and let them yield. As a first step, just remove all direct accesses to cur_mon so that we can implement this in the getter function later. Signed-off-by: Kevin Wolf --- include/monitor/monitor.h