Re: Ping: [PATCH v6] Emulate dip switch language layout settings on SUN keyboard

2023-06-10 Thread Henrik Carlqvist
Thanks for your thoughts on this! Getting the variable in ESCCChannelState instead of ESCCState is nice as it means that I don't have to add the ESCCState variable to the handle_kbd_command. So I will rewrite the patch to use argumetns like "-global escc.chrA-sunkbd-layout=sv" (or do we want it t

Re: Ping: [PATCH v6] Emulate dip switch language layout settings on SUN keyboard

2023-06-10 Thread Mark Cave-Ayland
On 08/06/2023 17:14, Henrik Carlqvist wrote: I didn't get much response to my last version of the patch to implement emulation of language selection dip switch on SUN keyboards. By request, I changed the patch to listen for -global escc.sunkbd_layout= instead of using the -k switch to select key

Re: [PATCH v6] Emulate dip switch language layout settings on SUN keyboard

2023-06-09 Thread Daniel P . Berrangé
On Thu, Jun 08, 2023 at 08:12:21PM +0200, Henrik Carlqvist wrote: > On Thu, 8 Jun 2023 17:22:23 +0100 > Daniel P. Berrangé wrote: > > > On Sun, Apr 30, 2023 at 10:55:33PM +0200, Henrik Carlqvist wrote: > > > What is the best way to document this kind of global parameters? > > > > You can put it

Re: [PATCH v6] Emulate dip switch language layout settings on SUN keyboard

2023-06-08 Thread Henrik Carlqvist
On Thu, 8 Jun 2023 17:22:23 +0100 Daniel P. Berrangé wrote: > On Sun, Apr 30, 2023 at 10:55:33PM +0200, Henrik Carlqvist wrote: > > What is the best way to document this kind of global parameters? > > You can put it in docs/system/sparc.rst (or sparc64.rst whichever is best?) Thanks for your r

Re: [PATCH v6] Emulate dip switch language layout settings on SUN keyboard

2023-06-08 Thread Daniel P . Berrangé
On Sun, Apr 30, 2023 at 10:55:33PM +0200, Henrik Carlqvist wrote: > I have now changed the patch to instead of using the -k switch use > > -global escc.sunkbd_layout= > > to select keyboard layout. It would be nice to somehow document this. Yes, in > the monitor, you can type "info qtree" and s

Ping: [PATCH v6] Emulate dip switch language layout settings on SUN keyboard

2023-06-08 Thread Henrik Carlqvist
I didn't get much response to my last version of the patch to implement emulation of language selection dip switch on SUN keyboards. By request, I changed the patch to listen for -global escc.sunkbd_layout= instead of using the -k switch to select keyboard layout. What do you think about this patc

Re: [PATCH v6] Emulate dip switch language layout settings on SUN keyboard

2023-04-30 Thread Henrik Carlqvist
I have now changed the patch to instead of using the -k switch use -global escc.sunkbd_layout= to select keyboard layout. It would be nice to somehow document this. Yes, in the monitor, you can type "info qtree" and see something like: dev: escc, id "" gpio-out "sysbus-irq" 2 frequen