Re: [PATCH v5 for-5.2] spapr: Use error_append_hint() in spapr_caps.c

2020-07-28 Thread David Gibson
On Tue, Jul 28, 2020 at 03:29:34PM +0200, Greg Kurz wrote: > We have a dedicated error API for hints. Use it instead of embedding > the hint in the error message, as recommanded in the "qapi/error.h" > header file. > > While here, have cap_fwnmi_apply(), which already uses > error_append_hint(), t

[PATCH v5 for-5.2] spapr: Use error_append_hint() in spapr_caps.c

2020-07-28 Thread Greg Kurz
We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. While here, have cap_fwnmi_apply(), which already uses error_append_hint(), to call ERRP_GUARD() as well. Signed-off-by: Greg Kurz Reviewed-by: Vl