Re: [PATCH v5 7/9] gdbstub: Make get cpu and hex conversion functions non-internal

2024-06-27 Thread Gustavo Romero
Hi Phil, Alex, On 6/27/24 9:26 AM, Philippe Mathieu-Daudé wrote: On 27/6/24 13:05, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 27/6/24 06:13, Gustavo Romero wrote: Make the gdb_first_attached_cpu and gdb_hextomem non-internal so they are not confined to use only in gdbstub.c. Signe

Re: [PATCH v5 7/9] gdbstub: Make get cpu and hex conversion functions non-internal

2024-06-27 Thread Philippe Mathieu-Daudé
On 27/6/24 13:05, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 27/6/24 06:13, Gustavo Romero wrote: Make the gdb_first_attached_cpu and gdb_hextomem non-internal so they are not confined to use only in gdbstub.c. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- gd

Re: [PATCH v5 7/9] gdbstub: Make get cpu and hex conversion functions non-internal

2024-06-27 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 27/6/24 06:13, Gustavo Romero wrote: >> Make the gdb_first_attached_cpu and gdb_hextomem non-internal so they >> are not confined to use only in gdbstub.c. >> Signed-off-by: Gustavo Romero >> Reviewed-by: Richard Henderson >> --- >> gdbstub/internals.h

Re: [PATCH v5 7/9] gdbstub: Make get cpu and hex conversion functions non-internal

2024-06-26 Thread Philippe Mathieu-Daudé
On 27/6/24 08:10, Philippe Mathieu-Daudé wrote: On 27/6/24 06:13, Gustavo Romero wrote: Make the gdb_first_attached_cpu and gdb_hextomem non-internal so they are not confined to use only in gdbstub.c. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson ---   gdbstub/internals.h  

Re: [PATCH v5 7/9] gdbstub: Make get cpu and hex conversion functions non-internal

2024-06-26 Thread Philippe Mathieu-Daudé
On 27/6/24 06:13, Gustavo Romero wrote: Make the gdb_first_attached_cpu and gdb_hextomem non-internal so they are not confined to use only in gdbstub.c. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- gdbstub/internals.h| 2 -- include/exec/gdbstub.h | 5 +

[PATCH v5 7/9] gdbstub: Make get cpu and hex conversion functions non-internal

2024-06-26 Thread Gustavo Romero
Make the gdb_first_attached_cpu and gdb_hextomem non-internal so they are not confined to use only in gdbstub.c. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- gdbstub/internals.h| 2 -- include/exec/gdbstub.h | 5 + include/gdbstub/commands.h | 6 ++ 3 fil