Re: [PATCH v5 4/6] python: add qapi static analysis tests

2025-06-05 Thread John Snow
On Thu, Jun 5, 2025 at 4:36 AM Daniel P. Berrangé wrote: > On Thu, Jun 05, 2025 at 08:33:44AM +0200, Markus Armbruster wrote: > > John Snow writes: > > > > [...] > > > > > diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh > > > new file mode 100755 > > > index 000..2

Re: [PATCH v5 4/6] python: add qapi static analysis tests

2025-06-05 Thread Daniel P . Berrangé
On Thu, Jun 05, 2025 at 08:33:44AM +0200, Markus Armbruster wrote: > John Snow writes: > > [...] > > > diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh > > new file mode 100755 > > index 000..2211b6c7f41 > > --- /dev/null > > +++ b/python/tests/qapi-flake8.sh > > @@

Re: [PATCH v5 4/6] python: add qapi static analysis tests

2025-06-04 Thread Markus Armbruster
John Snow writes: [...] > diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh > new file mode 100755 > index 000..2211b6c7f41 > --- /dev/null > +++ b/python/tests/qapi-flake8.sh > @@ -0,0 +1,6 @@ > +#!/bin/sh -e > +# SPDX-License-Identifier: LGPL-2.1-or-later Why not

Re: [PATCH v5 4/6] python: add qapi static analysis tests

2025-06-04 Thread Markus Armbruster
John Snow writes: > Update the python tests to also check QAPI and the QAPI Sphinx [Lovingly crafted commit message snipped...] > Signed-off-by: John Snow > > add licenses or whatever > > Signed-off-by: John Snow Oops!

[PATCH v5 4/6] python: add qapi static analysis tests

2025-06-04 Thread John Snow
Update the python tests to also check QAPI and the QAPI Sphinx extensions. The docs/sphinx/qapidoc_legacy.py file is not included in these checks, as it is destined for removal soon. mypy is also not called on the QAPI Sphinx extensions, owing to difficulties supporting Sphinx 3.x - 8.x while maint