Re: [PATCH v5 29/36] qapi/gen.py: Remove unused parameter

2020-10-07 Thread John Snow
On 10/7/20 8:22 AM, Markus Armbruster wrote: John Snow writes: module_basename doesn't use the 'what' argument, so remove it. _module_dirname(), I suppose. My brain just translates stuff I didn't ask it to all the time. (Fixed.) Signed-off-by: John Snow Reviewed-by: Eduardo Habkost R

Re: [PATCH v5 29/36] qapi/gen.py: Remove unused parameter

2020-10-07 Thread Markus Armbruster
John Snow writes: > module_basename doesn't use the 'what' argument, so remove it. _module_dirname(), I suppose. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > --- > scripts/qapi/gen.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

[PATCH v5 29/36] qapi/gen.py: Remove unused parameter

2020-10-05 Thread John Snow
module_basename doesn't use the 'what' argument, so remove it. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/gen.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py index d0391cd8