Re: [PATCH v5 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT

2023-10-29 Thread Akihiko Odaki
On 2023/10/30 6:56, Yuri Benditovich wrote: This patch allows  VIRTIO_NET_F_HASH_REPORT feature to the adapter whose backend does not have a virtio header and does not have offload features that depend on it. The migration between such different systems is very problematic even if it seems succ

Re: [PATCH v5 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT

2023-10-29 Thread Yuri Benditovich
This patch allows VIRTIO_NET_F_HASH_REPORT feature to the adapter whose backend does not have a virtio header and does not have offload features that depend on it. The migration between such different systems is very problematic even if it seems successful, such setups are not performance-oriented

Re: [PATCH v5 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT

2023-10-27 Thread Akihiko Odaki
On 2023/10/27 16:14, Jason Wang wrote: On Tue, Oct 17, 2023 at 12:14 PM Akihiko Odaki wrote: virtio-net can report hash values even if the peer does not have a virtio-net header. Do we need a compat flag for this? I don't think so. This change actually fixes the migration from a system wi

Re: [PATCH v5 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT

2023-10-27 Thread Jason Wang
On Tue, Oct 17, 2023 at 12:14 PM Akihiko Odaki wrote: > > virtio-net can report hash values even if the peer does not have a > virtio-net header. Do we need a compat flag for this? Thanks > > Signed-off-by: Akihiko Odaki > --- > hw/net/virtio-net.c | 2 -- > 1 file changed, 2 deletions(-) > >

[PATCH v5 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT

2023-10-16 Thread Akihiko Odaki
virtio-net can report hash values even if the peer does not have a virtio-net header. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index c6a92ba3db..dc2b7b8ee7 100644 --- a/hw/net/virtio-net.c